Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123257
Date: Fri, 03 May 2024 00:45:42 +0000
To: Derick Rethans <derick@php.net>
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function
Message-ID: <63GXg3pF4DIRrXn-zuvO46emeZTrmkMOuiLUFwDA18PdV0y8BNqFvwidOxktGf3Z8geBiwCksbQ-Jpzg9OaxPv6VxDJRDkWCE5S2kabhmF4=@gpb.moe>
In-Reply-To: <28215C90-191D-4159-9C47-86D03B9A683D@php.net>
References: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com> <28215C90-191D-4159-9C47-86D03B9A683D@php.net>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Thursday, 2 May 2024 at 21:33, Derick Rethans <derick@php.net> wrote:

> On 2 May 2024 13:48:36 BST, Ollie Read php@ollie.codes wrote:
>=20
> > These methods accept an integer to retrieve a parameter by its position=
, or a string to retrieve by its name. So far, I have built this so that if=
 you required the first parameter, it's parameter 0. I treat it this way be=
cause the only other place where we deal with parameter indexes, is Reflect=
ionFunctionAbstract::getParameters() which returns the parameters zero-inde=
xed.
> >=20
> > The question that is holding this PR back is should these methods be 1 =
indexed, so that the provided position is consistent with the error message=
s, or how a person would typically count, or should they be 0 indexed to re=
main consistent with the existing API.
>=20
>=20
> 0-indexed, as that's what PHP does everywhere else.
>=20
> cheers
> Derick

Well not really, if you have an error (TypeError or ValueError) which indic=
ate what parameter is the problem, it will be 1-indexed.

Which, for me, makes it more logical to have it 1-indexed.
If the ReflectionFunctionAbstract::getParameters() API did not exist, this =
is what I would have pushed for.

Moreover, PHP already has a 1-indexed and 0-indexed discrepancy with the ob=
_get_level() and ob_get_status() functions.

In the end, I don't really care what we choose, but this just needed clarif=
ication from internals on how to proceed.

Best regards,

Gina P. Banyard