Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123254
Precedence: bulk
MIME-Version: 1.0
References: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com>
In-Reply-To: <88ea5de8-22ea-4c23-b570-229acd546c10@app.fastmail.com>
Date: Thu, 2 May 2024 22:18:53 +0200
Message-ID: <CAEPJdu=OTak-Taj8pKAZcKFtMQFNMHDB+j4c=ymxqnpRwR1ing@mail.gmail.com>
Subject: Re: [PHP-DEV] Inconsistencies between parameter number and index when
 reflecting a method/function
To: Ollie Read <php@ollie.codes>
Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008a580206177e5068"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--0000000000008a580206177e5068
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 2, 2024 at 2:51=E2=80=AFPM Ollie Read <php@ollie.codes> wrote:

> Hi All,
>
> I've been working on a PR that introduces
> ReflectionFunctionAbstract::getParameter() and
> ReflectionFunctionAbstract::hasParameter(), to fall more inline with the
> other method sets we have, as well as just generally making peoples lives
> easier.
>
> The PR is here: https://github.com/php/php-src/pull/10431
>
> These methods accept an integer to retrieve a parameter by its position,
> or a string to retrieve by its name. So far, I have built this so that if
> you required the first parameter, it's parameter 0. I treat it this way
> because the only other place where we deal with parameter indexes, is
> ReflectionFunctionAbstract::getParameters() which returns the parameters
> zero-indexed.
>
> The question that is holding this PR back is should these methods be 1
> indexed, so that the provided position is consistent with the error
> messages, or how a person would typically count, or should they be 0
> indexed to remain consistent with the existing API.
>

PHP being a mostly zero indexed language I would say it should be
getParamter(0) to get the parameter #1 (referred to as 1 in error
messages).

>
> Girgias has asked that I pause the PR until we can have a discussion on
> this mailing list about how to approach it, so I'm looking for feedback o=
n
> this.
>
>
> ---
> Best Regards,
> *Ollie Read*
>
>

--0000000000008a580206177e5068
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, May 2, 2024 at 2:51=E2=80=AFP=
M Ollie Read &lt;php@ollie.codes&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-=
left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div =
class=3D"msg-8402907408477054289"><u></u><div><div>Hi All,<br></div><div><b=
r></div><div><div>I&#39;ve been working on a PR that introduces ReflectionF=
unctionAbstract::getParameter() and ReflectionFunctionAbstract::hasParamete=
r(), to fall more inline with the other method sets we have, as well as jus=
t generally making peoples lives easier.<br></div><div><br></div><div>The P=
R is here: <a href=3D"https://github.com/php/php-src/pull/10431" target=3D"=
_blank">https://github.com/php/php-src/pull/10431</a><br></div><div><br></d=
iv><div>These methods accept an integer to retrieve a parameter by its posi=
tion, or a string to retrieve by its name. So far, I have built this so tha=
t if you required the first parameter, it&#39;s parameter 0. I treat it thi=
s way because the only other place where we deal with parameter indexes, is=
 ReflectionFunctionAbstract::getParameters() which returns the parameters z=
ero-indexed.<br></div><div><br></div><div>The question that is holding this=
 PR back is should these methods be 1 indexed, so that the provided positio=
n is consistent with the error messages, or how a person would typically co=
unt, or should they be 0 indexed to remain consistent with the existing API=
.<br></div></div></div></div></blockquote><div><br></div><div>PHP being a m=
ostly zero indexed language I would say it should be getParamter(0) to get =
the parameter #1 (referred to as 1 in error messages).=C2=A0</div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-widt=
h:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-le=
ft:1ex"><div class=3D"msg-8402907408477054289"><div><div><div></div><div><b=
r></div><div>Girgias has asked that I pause the PR until we can have a disc=
ussion on this mailing list about how to approach it, so I&#39;m looking fo=
r feedback on this.<br></div><br></div><div><br></div><div id=3D"m_-8402907=
408477054289sig125548165"><div>---<br></div><div>Best Regards,<br></div><di=
v><b>Ollie Read</b><br></div></div><div><br></div></div></div></blockquote>=
</div></div>

--0000000000008a580206177e5068--