Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123194
Precedence: bulk
MIME-Version: 1.0
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com> <CAAKU0ukwfF+D5L+23BEqL053ktCp5AQOjRGdha-8pXN-yf1HBQ@mail.gmail.com>
 <06373f2b-5de0-4582-96c5-29c3b474c01d@wcflabs.de> <45e6365b-4963-4969-8cc1-80bae6922fc8@wcflabs.de>
In-Reply-To: <45e6365b-4963-4969-8cc1-80bae6922fc8@wcflabs.de>
Date: Tue, 23 Apr 2024 14:22:11 -0600
Message-ID: <CAAKU0umBsEeJroVXVmjKLCfEt2LxnJCjaX7sxxNJqChYA1fwvw@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
To: =?UTF-8?Q?Joshua_R=C3=BCsweg?= <josh@wcflabs.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: levi.morrison@datadoghq.com (Levi Morrison)

On Tue, Apr 23, 2024 at 1:53=E2=80=AFPM Joshua R=C3=BCsweg <josh@wcflabs.de=
> wrote:
>
> Hi
>
> On 19.04.24 21:20, Joshua R=C3=BCsweg wrote:
> > I definitely see the point where there is an advantage to having two
> > separate methods and can definitely understand that it is easier for
> > developers to understand the control flow without evaluating the
> > parameters.
> >
> > I'm unsure if that's really necessary though, because basically it's
> > probably not necessary to directly see what exactly the function
> > returns. Perhaps there will be another opinion on this in an email in
> > the next few days.
>
> Now that I've thought about it for a few days, it's really better that
> the whole thing is broken down into two methods. I have adjusted the RFC
> accordingly. The RFC contains now two separat functions `array_find` and
> `array_find_key`.
>
> Cheers
>
> Josh

The RFC looks better to me. The
[Unaffected PHP Functionality][1] section looks like it needs
updating, though:

> This RFC only adds two new functions and an enum to PHP and
> only affects previously defined functions which are named as
> the proposed function or enum.

I don't see an enum in the text nor in the git diff.

  [1]: https://wiki.php.net/rfc/array_find#unaffected_php_functionality