Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123193
Message-ID: <45e6365b-4963-4969-8cc1-80bae6922fc8@wcflabs.de>
Date: Tue, 23 Apr 2024 21:53:08 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
Content-Language: de-DE
To: Levi Morrison <levi.morrison@datadoghq.com>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
 <CAAKU0ukwfF+D5L+23BEqL053ktCp5AQOjRGdha-8pXN-yf1HBQ@mail.gmail.com>
 <06373f2b-5de0-4582-96c5-29c3b474c01d@wcflabs.de>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <06373f2b-5de0-4582-96c5-29c3b474c01d@wcflabs.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: josh@wcflabs.de ("=?UTF-8?Q?Joshua_R=C3=BCsweg?=")

Hi

On 19.04.24 21:20, Joshua Rüsweg wrote:
> I definitely see the point where there is an advantage to having two 
> separate methods and can definitely understand that it is easier for 
> developers to understand the control flow without evaluating the 
> parameters.
> 
> I'm unsure if that's really necessary though, because basically it's 
> probably not necessary to directly see what exactly the function 
> returns. Perhaps there will be another opinion on this in an email in 
> the next few days.

Now that I've thought about it for a few days, it's really better that 
the whole thing is broken down into two methods. I have adjusted the RFC 
accordingly. The RFC contains now two separat functions `array_find` and 
`array_find_key`.

Cheers

Josh