Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123188
Feedback-ID: i6f4c46c2:Fastmail
Message-ID: <e7cdbbcb-3d1d-4d43-b592-61af47fee7b0@beccati.com>
Date: Tue, 23 Apr 2024 18:41:38 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers
To: "internals@lists.php.net" <internals@lists.php.net>
Cc: Saki Takamachi <saki@sakiot.com>
References: <ff5785b8-ba73-4302-9e1a-afaba34650bb@beccati.com>
 <00079548-1799-4215-8F73-EFDCD795532F@sakiot.com>
 <098996d6-32e4-460c-a82a-aeef3b7e61d3@beccati.com>
 <9A6577BD-3BC5-41E1-965D-4B30D16CDB3D@sakiot.com>
Content-Language: it
In-Reply-To: <9A6577BD-3BC5-41E1-965D-4B30D16CDB3D@sakiot.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
From: php@beccati.com (Matteo Beccati)

Hi Saki, internals,

Il 17/04/2024 16:30, Saki Takamachi ha scritto:
> Hi Matteo,
> 
>> Thanks for the feedback. I will reference this issue as duplicate too in the RFC.
> 
> Thanks for the reference to the issue.
> 
> 
>> I'm certain if we dig deep enough we'll find a few more.
> 
> Agree. Maybe we can find something other than PostgreSQL.
> 
> 
> I have read through your RFC. If we change the default scanner from the current, is there a possibility that an unintended BC Break will occur? I don't think there is a problem with MySQL, but I'm a little worried about other drivers.

I have updated the RFC quite extensively. I've added the results of the 
research I've done for all the supported PDO database types and ended up 
slightly modifying the proposal in a way I thought made more sense 
according to the results.

I also have a draft implementation ready: 
https://github.com/php/php-src/pull/14035

Tests are green. DBAL tests are green for sqlite, mysql and pgsql, which 
is what I could test locally.


And as an exercise, an attempt to support PgSQL escape literals, e.g.

e'backslashes \'accepted\' here'

https://github.com/mbeccati/php-src/pull/1/commits/79b59d958c43042e54348dfbae0b0c2509563aa7

which I declared as out of scope but could in fact be supported without 
too much effort.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/