Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123162
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849
Precedence: bulk
MIME-Version: 1.0
Message-ID: <4bdc94d9-f35b-423a-b3a7-1a91fbf48424@app.fastmail.com>
In-Reply-To: <cf6fed0d-ec60-4766-a594-34be1ee258d5@wcflabs.de>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
 <45b726f4-8085-43e2-b701-6b35bc249409@wcflabs.de>
 <d8a92e7a-539e-4753-bd27-5d59b17779ba@bastelstu.be>
 <2dd7ef64-d1c5-4ed8-964f-b86dba110e0d@app.fastmail.com>
 <cf6fed0d-ec60-4766-a594-34be1ee258d5@wcflabs.de>
Date: Fri, 19 Apr 2024 20:08:34 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, Apr 19, 2024, at 7:34 PM, Joshua R=C3=BCsweg wrote:
> Hi
>
> On 10.04.24 00:12, Larry Garfield wrote:
>> Another alternative is to always return the key, because you can triv=
ially get the value from the key, but not vice versa.  Of course, the re=
sulting syntax for that is frequently fugly.
>>=20
>> $val =3D $array[array_find($db, $array)] ?? some-default;
>
>
> In 95% (roughly) of cases, I (personally) need the array value and not=20
> the key. Just having the option to get the key is already a step forwa=
rd=20
> compared to the current state, but I personally would find it=20
> impractical (and fugly, as you said) to use the method, especially if=20
> the search callback is more complex and multi-line (and it is fugly, a=
s=20
> you said).
>
> Here is an example for this, without using a helper variable:
>
> $value =3D $array[\array_find($array, function ($value, $key): bool {
>      if ($key % 5) {
>          return \strlen($value) < 100;
>      }
>
>      if ($key % 2) {
>          return \strlen($value) < 40;
>      }
>
>      return false;
> })];
>
> So I think, this is not an option.
>
> Cheers
>
> Josh

I think at this point I'm on team "let's just make it 2 separate functio=
ns, give them good names, and move on with life."

There's another issue, though: Will the callback always be given both $v=
alue and $key?  If so, it's incompatible with internal single-parameter =
functions.  If not, and it tries to auto-detect, we run into issues with=
 functions with optional second arguments.  (This is a pre-existing mess=
 I've run into before.)

--Larry Garfield