Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123160
Message-ID: <06373f2b-5de0-4582-96c5-29c3b474c01d@wcflabs.de>
Date: Fri, 19 Apr 2024 21:20:10 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
Content-Language: de-DE
To: Levi Morrison <levi.morrison@datadoghq.com>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
 <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
 <CAAKU0ukwfF+D5L+23BEqL053ktCp5AQOjRGdha-8pXN-yf1HBQ@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CAAKU0ukwfF+D5L+23BEqL053ktCp5AQOjRGdha-8pXN-yf1HBQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
From: josh@wcflabs.de ("=?UTF-8?Q?Joshua_R=C3=BCsweg?=")



On 11.04.24 03:03, Levi Morrison wrote:
> IMO, it's better to separate it into two functions because its type is
> stable without control flow. For instance:
> 
>      // Returns K if $b is true, V otherwise.
>      function array_find(
>          array<K, V> $array,
>          callable(V, K): bool $callback,
>          bool $b = false
>      ) -> K|V;
> 
> This isn't stable and requires control-flow to understand the type.
> These are simpler:
> 
>      function array_find(
>          array<K, V> $array,
>          callable(V, K): bool $callback
>      ) -> V;
> 
>      function array_find_key(
>          array<K, V> $array,
>          callable(V, K): bool $callback
>      ) -> K;
> 
> Naming bikeshedding aside, it's better to have types that are
> inferrable without function-specific knowledge of control flow. It
> doesn't matter if it's a bool or an enum, it still has problems.
> Better to just separate them to different functions.

I definitely see the point where there is an advantage to having two 
separate methods and can definitely understand that it is easier for 
developers to understand the control flow without evaluating the parameters.

I'm unsure if that's really necessary though, because basically it's 
probably not necessary to directly see what exactly the function 
returns. Perhaps there will be another opinion on this in an email in 
the next few days.

Cheers

Josh