Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123148
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849
Precedence: bulk
MIME-Version: 1.0
Message-ID: <26c47eb5-a60a-459d-89e6-16f6f0634cba@app.fastmail.com>
In-Reply-To: <a38f4b1c-bb6d-47e2-9220-21493584a5f6@beccati.com>
References: <ff5785b8-ba73-4302-9e1a-afaba34650bb@beccati.com>
 <00079548-1799-4215-8F73-EFDCD795532F@sakiot.com>
 <098996d6-32e4-460c-a82a-aeef3b7e61d3@beccati.com>
 <9A6577BD-3BC5-41E1-965D-4B30D16CDB3D@sakiot.com>
 <a38f4b1c-bb6d-47e2-9220-21493584a5f6@beccati.com>
Date: Wed, 17 Apr 2024 14:51:47 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Apr 17, 2024, at 2:45 PM, Matteo Beccati wrote:
> Hi Saki,
>
> Il 17/04/2024 16:30, Saki Takamachi ha scritto:
>> Hi Matteo,
>> 
>>> Thanks for the feedback. I will reference this issue as duplicate too in the RFC.
>> 
>> Thanks for the reference to the issue.
>> 
>> 
>>> I'm certain if we dig deep enough we'll find a few more.
>> 
>> Agree. Maybe we can find something other than PostgreSQL.
>> 
>> 
>> I have read through your RFC. If we change the default scanner from the current, is there a possibility that an unintended BC Break will occur? I don't think there is a problem with MySQL, but I'm a little worried about other drivers.
>
> I did a quick research and both Oracle and SQL Server seem only to 
> understand double single quotes.
>
> I agree we need more research, but it's already 4 database drivers we'd 
> be fixing by switching the default parser to standard SQL quotes.

This all seems logical, but having separate parsers would mean that the SQL strings are no longer portable, yes?  Eg, many frameworks and CMSes try to (claim to) support multiple DBs transparently.  (MySQL and Postgres and SQLite, usually).  Some even recommend using SQLite for testing, but MySQL for prod.  This change would break that, wouldn't it?  Because the escaping would necessarily be different for MySQL and SQLite, and thus the queries would break on one or the other?

--Larry Garfield