Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123135
Precedence: bulk
MIME-Version: 1.0
References: <CAEPPVa3oV_e6gHAojWqfb9eW7QPP3371r4jsL6a7thcjTFVZ2g@mail.gmail.com>
 <733732ea-7b2a-473c-9f65-6ef975404543@bastelstu.be> <CAEPPVa0Z55xX49LPKmRyLq_U8odUWH+D9THYGYgVbSi5UC3mXw@mail.gmail.com>
 <CAOWwgp=iX-=VvMh_mpRxFQEHPKFNw-Ypun7ReNrZ0ekYNx4REg@mail.gmail.com>
In-Reply-To: <CAOWwgp=iX-=VvMh_mpRxFQEHPKFNw-Ypun7ReNrZ0ekYNx4REg@mail.gmail.com>
Date: Mon, 15 Apr 2024 10:11:24 +0900
Message-ID: <CAEPPVa0YvRyTDKeJTA6yiJst9dy-xnndT4ryU8cP-UbQmy0dLQ@mail.gmail.com>
Subject: Re: [PHP-DEV][DISCUSSION] Fix mb_trim inaccurate $character
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: youkidearitai@gmail.com (youkidearitai)

2024=E5=B9=B44=E6=9C=8812=E6=97=A5(=E9=87=91) 18:32 Nicolas Grekas <nicolas=
.grekas+php@gmail.com>:
>
> Hi
>
> Le jeu. 4 avr. 2024 =C3=A0 07:41, youkidearitai <youkidearitai@gmail.com>=
 a =C3=A9crit :
>>
>> 2024=E5=B9=B44=E6=9C=884=E6=97=A5(=E6=9C=A8) 6:30 Tim D=C3=BCsterhus <ti=
m@bastelstu.be>:
>> >
>> > Hi
>> >
>> > On 4/3/24 10:02, youkidearitai wrote:
>> > > Therefore, I think require an RFC, I have written a draft an RFC tha=
t
>> > > fixes these issues.
>> > > https://wiki.php.net/rfc/mb_trim_change_characters
>> >
>> > I don't think this (widening the type and changing the default value t=
o
>> > obtain the *intended* behavior) requires an RFC. It's a bugfix, a bugf=
ix
>> > with a slightly larger observable impact than other bugfixes.
>> >
>> > Best regards
>> > Tim D=C3=BCsterhus
>>
>> Hi
>> Thank you very much for comment.
>>
>> I would like to discuss this RFC with all of you, as we have not yet
>> decided on the correct revision policy.
>> I created the RFC for that purpose.
>>
>> Still waiting for your comments!
>> Thank you.
>>
>
> I also don't think this requires an RFC. This is a minor design issue tha=
t has only one possible solution, so there is little to discuss.
>
> Cheers,
> Nicolas

Hi,

I appreciate late my response.
I got it. I modified original an RFC
(https://wiki.php.net/rfc/mb_trim) that $character is default
parameter.
Please point out any problems, I revert it.

Regards
Yuya

--=20
---------------------------
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-----------------------------