Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123133
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849
Precedence: bulk
MIME-Version: 1.0
Message-ID: <9d8db5e0-89cf-4c19-9c9e-2a24228e1a02@app.fastmail.com>
In-Reply-To: <c7d2adb0-0035-482a-a124-11bf30d10212@bastelstu.be>
References: 
 <KOnrDbR12WyDnAayphg_Avxa0gkLH_tfd7DCtkMPbG1FjMSUVXIB1uKJTgboiVao3RCwNMHYP5_G5ixEudQxMRmIJ-PnYG3-RwJJ03qRh7Y=@gpb.moe>
 <c7d2adb0-0035-482a-a124-11bf30d10212@bastelstu.be>
Date: Sun, 14 Apr 2024 13:25:03 -0500
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] Incorrect terminology usage for rounding modes of round()
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, Apr 14, 2024, at 11:49 AM, Tim D=C3=BCsterhus wrote:
> Hi
>
> On 4/14/24 16:33, Gina P. Banyard wrote:
>> Considering that PHP 8.4 is also adding new rounding modes via the "A=
dd 4 new rounding modes to round() function" RFC [4] attempting to solve=
 this issue in this next version of PHP seems like a good idea.
>> In my discussions with Saki about this issue, it seems that her and T=
im have thought about creating a new enum for rounding modes, looking so=
mething like this:
>>=20
>> enum RoundingMode {
>>      case HalfAwayFromZero;
>>      case HalfTowardsZero;
>>      case HalfEven;
>>      case HalfOdd;
>>      case TowardsZero;
>>      case AwayFromZero;
>>      case NegativeInfinity; // or case Floor;
>>      case PositiveInfinity; // or case Ceiling;
>> }

> For PHP 8.4, I'd first make it `int|RoundingMode` to keep the constant=20
> values the same (in case the constants are re-used by a userland=20
> library). Narrowing it down to just RoundingMode and updating the=20
> constants can happen in a later version.

I support this change.  While I don't know who would be using the roundi=
ng mode constants for other purposes, I'm not opposed to taking a more g=
radual approach if that's the consensus.  At least a version would allow=
 people time to realize, oops, I should not use someone else's constants=
. :-)

I also don't have a strong opinion between making it global vs a Math na=
mespace.  (But as Derick notes, not Maths, for consistency.)

--Larry Garfield