Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123111
Precedence: bulk
MIME-Version: 1.0
References: <CAPzBOBMJcZPpn_DaUUrcsPC=ty53XLgqq=LrOd81Y0qNgqMsNA@mail.gmail.com>
In-Reply-To: <CAPzBOBMJcZPpn_DaUUrcsPC=ty53XLgqq=LrOd81Y0qNgqMsNA@mail.gmail.com>
Date: Thu, 11 Apr 2024 16:11:21 +0200
Message-ID: <CADU7aos3SJ08gGb3v0dbHODosv+HnAEfTcB3_R0_nexUgytgTg@mail.gmail.com>
Subject: [PHP-DEV] Re: [proposal] max_execution_time to a negative number
To: Robert Landers <landers.robert@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006d9ebb0615d2bb1d"
From: kevin@dunglas.fr (=?UTF-8?Q?K=C3=A9vin_Dunglas?=)

--0000000000006d9ebb0615d2bb1d
Content-Type: text/plain; charset="UTF-8"

According to "man 2 setitimer", the same error should happen on Linux even
without zend_max_execution_timer:
https://github.com/php/php-src/blob/2079da0158bc91fff4edd85ac66c89b40c4faf3a/Zend/zend_execute_API.c#L1566

A C error will also occur if the value is superior to 999,999,999.

We should at least prevent the C error in such cases. I proposed a patch
normalizing these values to 0: https://github.com/php/php-src/pull/13942
It's still better than the current situation, and can still be considered
as "undefined" until the RFC is voted.

--0000000000006d9ebb0615d2bb1d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>According to &quot;man 2 setitimer&q=
uot;, the same error should happen on Linux even without zend_max_execution=
_timer: <a href=3D"https://github.com/php/php-src/blob/2079da0158bc91fff4ed=
d85ac66c89b40c4faf3a/Zend/zend_execute_API.c#L1566">https://github.com/php/=
php-src/blob/2079da0158bc91fff4edd85ac66c89b40c4faf3a/Zend/zend_execute_API=
.c#L1566</a></div><div><br></div><div>A C error will also occur if the valu=
e is superior to 999,999,999.</div><div><br></div><div>We should at least p=
revent the C error in such cases. I proposed a patch normalizing these valu=
es to 0: <a href=3D"https://github.com/php/php-src/pull/13942">https://gith=
ub.com/php/php-src/pull/13942</a></div><div>It&#39;s still better than the =
current situation, and can still be considered as &quot;undefined&quot; unt=
il the RFC is voted.</div></div></div>

--0000000000006d9ebb0615d2bb1d--