Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123016
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542
Precedence: bulk
MIME-Version: 1.0
Message-ID: <278889be-82ab-4827-a9e7-801b5ba2d8f8@app.fastmail.com>
In-Reply-To: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
References: <24e4529d-0b75-44de-90ef-34de5dfb1c99@wcflabs.de>
Date: Sun, 07 Apr 2024 10:35:18 -0400
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] RFC [Discussion]: array_find
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, Apr 7, 2024, at 10:20 AM, Joshua R=C3=BCsweg wrote:
> Hi=20
> I have created an RFC to add the function array_find which returns the=20
> first element for which a predicate callback returns true. This is a=20
> function which I missed often. Furthermore this type of function is=20
> implemented with other programming languages like C++, JavaScript and=20
> Rust, too.=20
> You can find the RFC at:=20
> https://wiki.php.net/rfc/array_find
> Proof of concept implementation is in:
> https://github.com/joshuaruesweg/php-src/commit/9f3fc252b92f534d498e5f=
1e6a463e15f45da208
> I'm looking forward to your feedback.
> Cheers
> Joshua R=C3=BCsweg

I'm open to this, but two points that I'm sure someone will bring up:

1. Should this work on arrays or iterables?  This is a long standing lim=
itation of PHP.  The array operations don't work on iterables, even thou=
gh we've had iterables for 20 years.)

2. Key handling.  It's good that you have looked into this, because I wa=
s going to mention it. :-)  However, I don't think a boolean is the righ=
t answer, since the question is binary, not true/false.  (Those are not =
the same thing.)  I think a small return-mode Enum would make more sense=
 here.

--Larry Garfield