Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122970
Precedence: bulk
MIME-Version: 1.0
References: <CAF-fPAk0JxToi=dEupJHOEhsb3QiA-M1x_9znAFXfDSbCxvNzQ@mail.gmail.com>
In-Reply-To: <CAF-fPAk0JxToi=dEupJHOEhsb3QiA-M1x_9znAFXfDSbCxvNzQ@mail.gmail.com>
Date: Fri, 5 Apr 2024 15:58:52 +0200
Message-ID: <CAPyj-LCLc4XF=yndX8ecT1xnTP=yzziUm4ttu86uKMfdF=8W5g@mail.gmail.com>
Subject: Re: [PHP-DEV] Proposal: retrieve line, filename and if user defined
 for ReflectionAttribute
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Joel

On Fri, Apr 5, 2024 at 3:10=E2=80=AFPM Joel Wurtz <jwurtz@jolicode.com> wro=
te:
>
> Like a lot of libraries, we offer the possibility to configure behaviors =
with Attributes. However in some cases it's wrongly configured by the user =
and this wrong configuration cannot be detected on the attribute constructo=
r but afterwards.
>
> In this case we may want to pinpoint which attribute (in which file and a=
t which line) cause this bad configuration. Since there was no method to re=
trieve those information in the ReflectionAttribute I proposed a PR https:/=
/github.com/php/php-src/pull/13889 to add those informations.
>
> I do believe this will allow better DX for end user when correctly used,

I would propose negating and renaming isUserDefined() to isInternal(),
since we already have several such methods. As hinted in the PR, I
believe the implementation is wrong, or rather doesn't do what you
would expect it to do.

I'm also wondering whether it may be more useful to expose the
attribute class as getClass(), without instantiating the attribute
itself. This would allow you to check for isInternal() there, along
with all the other class reflection information.

Ilija