Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122956
Message-ID: <32ccbf49-dd3c-49c7-a33f-c85566acc72d@processus.org>
Date: Fri, 5 Apr 2024 09:11:54 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC idea: using the void type to control maximum arity
 of user-defined functions
To: Mark Trapp <mark@itafroma.com>, internals@lists.php.net
References: <6299b649-c19b-4172-9632-2ef0a55d256d@uzy.me>
 <CA+pig-JBkZip5bEM0gSwcwNRO9NDKuRO2vu=iHnx2diBTv9Bng@mail.gmail.com>
 <7B32AF65-CA40-40F5-BA59-CB5180EC4D7F@gmail.com>
 <8f71d807-78e6-49f6-acc7-b1fc09d815ba@uzy.me>
 <989e3e13-48ee-4970-8485-f79bb70ad37c@bastelstu.be>
 <fa198b2d-9e20-4c2e-b92d-254da6df5b8d@scriptfusion.com>
 <3B22ABD9-7F0F-4772-B47A-FD0A7068F63D@itafroma.com>
Content-Language: fr-FR, en-US
In-Reply-To: <3B22ABD9-7F0F-4772-B47A-FD0A7068F63D@itafroma.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: pierre-php@processus.org (Pierre)

Le 04/04/2024 à 23:38, Mark Trapp a écrit :
> On Thu, Apr 4, 2024 at 2:16 PM Bilge <bilge@scriptfusion.com> wrote:
>> On 04/04/2024 16:57, Tim Düsterhus wrote:
>>> I think it would be reasonable to consider deprecating passing extra
>>> arguments to a non-variadic function.
>> This seems like the only reasonable thing to do, to me. If this were the
>> case, there should be no need for any new syntax, since we could simply
>> deny passing extra arguments in the next major, no?
>>
>> Bilge
> I'd caution about being too hasty to deprecate and remove support for
> this feature without understanding the underlying reasons why it has
> been used historically, and without providing a better (not just
> different) alternative for those use cases, lest an impossible upgrade
> path is created.
>
> While the variadic operator should be a 1:1 replacement for using
> func_get_args(), is it enough of a benefit to force potentially tens
> of thousands of codebases to change when they both accomplish the same
> thing? What bad thing happens if PHP continues to support both
> methods?
>
> There is already enough friction to upgrade between major versions.
> Introducing an optional attribute or syntax allows codebases that care
> about signature strictness get that safety, while avoiding a
> potentially costly and onerous upgrade for the community.
>
> - Mark

I agree with both, ie. I think it's reasonable to deprecate extra 
variadic arguments, but also do it with caution: some old code, some 
templating systems for example may use implicit variadic arguments to 
pass values to templates.

There are tons of use case like this in old yet still running code.

But I would love it to be deprecated, raise warnings, and give some time 
for people to fix (adding an explicit `mixed ... $values` is enough to 
fix broken code).

Cheers,

--

Pierre