Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122940
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542
Precedence: bulk
MIME-Version: 1.0
Message-ID: <c7895861-4f34-4f9d-b54d-f413aa40849f@app.fastmail.com>
In-Reply-To: <5969054f-1959-46a6-be5f-4de4550f2025@bastelstu.be>
References: <6299b649-c19b-4172-9632-2ef0a55d256d@uzy.me>
 <CA+pig-JBkZip5bEM0gSwcwNRO9NDKuRO2vu=iHnx2diBTv9Bng@mail.gmail.com>
 <67221462-6c9f-48d7-8c59-e7262a744ff5@uzy.me>
 <CAEwRQKYgf-Qj0k=uJdZo0uwZKkE75g2Xg3R-ZmBdvAcm8EaW=Q@mail.gmail.com>
 <5969054f-1959-46a6-be5f-4de4550f2025@bastelstu.be>
Date: Thu, 04 Apr 2024 16:19:40 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] RFC idea: using the void type to control maximum arity of
 user-defined functions
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Apr 4, 2024, at 3:49 PM, Tim D=C3=BCsterhus wrote:
> Hi
>
> On 4/4/24 17:40, Vinicius Dias wrote:
>>> I like this concept, but instead of introducing a new syntax, have y=
ou
>>> considered leveraging attributes in the same way that PHP 8.3
>>> introduced #[Override]?
>>>
>>> #[Nonvariadic]
>>> function foo () {}
>>> foo(42); // warning: foo() expects exactly 0 arguments, 1 given
>>>
>>> I think the intent would be clearer and it would avoid introducing a=
 new syntax.
>>>
>>=20
>> I agree that using an attribute would be better for this case.
>
> I disagree with an attribute being the right choice here. In contrast =
to=20
> #[\Override], this proposal changes the behavior for the *caller* of t=
he=20
> function and likely also requires adjustments in child classes when=20
> newly introduced in a parent class or interface.
>
> Thus it is part of the function's API and thus should be part of the=20
> regular signature and not the attribute-based metadata.
>
> Best regards
> Tim D=C3=BCsterhus

I would think following the pattern of dynamic properties would make the=
 most sense.  Require an opt-in via attribute, with deprecation period. =
 And possibly just remove the functionality at some point in the future.

The core issue here IMO isn't the behavior itself, but the inconsistency=
.  C-implemented functions reject extra args.  PHP-implemented functions=
 ignore them (modulo variadics).  This is... a total mess that has bitte=
n me more than I want to admit.  Normalizing it one way or the other wou=
ld be a win.

--Larry Garfield