Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122938
Message-ID: <5969054f-1959-46a6-be5f-4de4550f2025@bastelstu.be>
Date: Thu, 4 Apr 2024 17:49:03 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] RFC idea: using the void type to control maximum arity
 of user-defined functions
To: Vinicius Dias <carlosv775@gmail.com>, Pablo Rauzy <r@uzy.me>
Cc: Mark Trapp <mark@itafroma.com>, internals@lists.php.net
References: <6299b649-c19b-4172-9632-2ef0a55d256d@uzy.me>
 <CA+pig-JBkZip5bEM0gSwcwNRO9NDKuRO2vu=iHnx2diBTv9Bng@mail.gmail.com>
 <67221462-6c9f-48d7-8c59-e7262a744ff5@uzy.me>
 <CAEwRQKYgf-Qj0k=uJdZo0uwZKkE75g2Xg3R-ZmBdvAcm8EaW=Q@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAEwRQKYgf-Qj0k=uJdZo0uwZKkE75g2Xg3R-ZmBdvAcm8EaW=Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 4/4/24 17:40, Vinicius Dias wrote:
>> I like this concept, but instead of introducing a new syntax, have you
>> considered leveraging attributes in the same way that PHP 8.3
>> introduced #[Override]?
>>
>> #[Nonvariadic]
>> function foo () {}
>> foo(42); // warning: foo() expects exactly 0 arguments, 1 given
>>
>> I think the intent would be clearer and it would avoid introducing a new syntax.
>>
> 
> I agree that using an attribute would be better for this case.

I disagree with an attribute being the right choice here. In contrast to 
#[\Override], this proposal changes the behavior for the *caller* of the 
function and likely also requires adjustments in child classes when 
newly introduced in a parent class or interface.

Thus it is part of the function's API and thus should be part of the 
regular signature and not the attribute-based metadata.

Best regards
Tim Düsterhus