Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122936
Precedence: bulk
MIME-Version: 1.0
References: <6299b649-c19b-4172-9632-2ef0a55d256d@uzy.me> <CA+pig-JBkZip5bEM0gSwcwNRO9NDKuRO2vu=iHnx2diBTv9Bng@mail.gmail.com>
 <67221462-6c9f-48d7-8c59-e7262a744ff5@uzy.me>
In-Reply-To: <67221462-6c9f-48d7-8c59-e7262a744ff5@uzy.me>
Date: Thu, 4 Apr 2024 12:40:59 -0300
Message-ID: <CAEwRQKYgf-Qj0k=uJdZo0uwZKkE75g2Xg3R-ZmBdvAcm8EaW=Q@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC idea: using the void type to control maximum arity
 of user-defined functions
To: Pablo Rauzy <r@uzy.me>
Cc: Mark Trapp <mark@itafroma.com>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: carlosv775@gmail.com (Vinicius Dias)

> I like this concept, but instead of introducing a new syntax, have you
> considered leveraging attributes in the same way that PHP 8.3
> introduced #[Override]?
>
> #[Nonvariadic]
> function foo () {}
> foo(42); // warning: foo() expects exactly 0 arguments, 1 given
>
> I think the intent would be clearer and it would avoid introducing a new =
syntax.
>

I agree that using an attribute would be better for this case.


> I would personally prefer the void syntax, but that's really because attr=
ibutes look odd to me due to lack of habits (and also because it avoids an =
additional line of code=E2=80=A6 which is probably not a solid enough reaso=
n when it comes to language design decisions).


As a reader of the code, having the attribute is much more clear to me
than having something that looks like an argument.
Also, with attributes, the code is backwards-compatible, i.e., I can
add the attribute to my code without any errors or warnings even if I
don't use the latest version of PHP, and even in those cases, IDEs
could still help me.