Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122890
Precedence: bulk
MIME-Version: 1.0
References: <CAPyj-LA7kJLdz3Pzbxr6x-7v2YV8n06pwxs6QoVe3CGgx-_GGA@mail.gmail.com>
 <1a4a44c5-d4f5-40ca-b3dc-13d64c2b4425@app.fastmail.com> <CAPyj-LBS5iUEX_Y9gqGL_vsFjTgZCsDT3YUGQgZw43oFVE2XiA@mail.gmail.com>
In-Reply-To: <CAPyj-LBS5iUEX_Y9gqGL_vsFjTgZCsDT3YUGQgZw43oFVE2XiA@mail.gmail.com>
Date: Tue, 2 Apr 2024 20:51:49 +0200
Message-ID: <CA+hqhpc65J8gJLNTGMrhcAWQ2_+vqp9XmG2dKNQxTLP0tAjwSg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: weirdan@gmail.com (Bruce Weirdan)

On Tue, Apr 2, 2024 at 8:05=E2=80=AFPM Ilija Tovilo <tovilo.ilija@gmail.com=
> wrote:

> Equality for data objects is based on data, rather than the object
> handle.

I believe equality should always consider the type of the object.

```php
new Problem(size:'big') =3D=3D=3D new Universe(size:'big')
&& new Problem(size:'big') =3D=3D=3D new Shoe(size:'big');
```

If the above can ever be true then I'm not sure how big is the problem
(but probably very big).
Also see the examples of non-comparable ids - `new CompanyId(1)`
should not be equal to `new PersonId(1)`

And I'd find it very confusing if the following crashed

```php
function f(Universe $_u): void {}
$universe =3D new Universe(size:'big');
$shoe =3D new Shoe(size:'big);

if ($shoe =3D=3D=3D $universe) {
   f($shoe); // shoe is *identical* to the universe, so it should be
accepted wherever the universe is
}
```

--=20
  Best regards,
      Bruce Weirdan                                     mailto:weirdan@gmai=
l.com