Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12288 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40577 invoked by uid 1010); 23 Aug 2004 07:20:51 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40538 invoked from network); 23 Aug 2004 07:20:50 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 23 Aug 2004 07:20:50 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7N7Koe1022203 for ; Mon, 23 Aug 2004 03:20:50 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7N7Kda20761 for ; Mon, 23 Aug 2004 03:20:39 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id i7N7KcHP023938 for ; Mon, 23 Aug 2004 08:20:38 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id i7N7KbmS023937 for internals@lists.php.net; Mon, 23 Aug 2004 08:20:37 +0100 Date: Mon, 23 Aug 2004 08:20:37 +0100 To: internals@lists.php.net Message-ID: <20040823072037.GA23931@redhat.com> Mail-Followup-To: internals@lists.php.net Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] apache2* config.m4 update (resend) From: jorton@redhat.com (Joe Orton) This fixes the 2.0 SAPI build against HEAD of httpd-2.0: 1. pick up correct names for ap[ru]-config from apxs 2. pick up --cppflags etc from apr-config to ensure that -D_LARGEFILE64_SOURCE is used where necessary (that's bug #27761) since APR now has large file support (tested to not break the build against the 2.0.x branch) Index: sapi/apache2filter/config.m4 =================================================================== RCS file: /repository/php-src/sapi/apache2filter/config.m4,v retrieving revision 1.36 diff -u -r1.36 config.m4 --- sapi/apache2filter/config.m4 3 Oct 2003 05:24:27 -0000 1.36 +++ sapi/apache2filter/config.m4 23 Aug 2004 07:14:35 -0000 @@ -40,8 +40,14 @@ APU_BINDIR=`$APXS -q APU_BINDIR` APR_BINDIR=`$APXS -q APR_BINDIR` - APU_INCLUDEDIR="`$APU_BINDIR/apu-config --includes`" - APR_INCLUDEDIR="`$APR_BINDIR/apr-config --includes`" + # Pick up ap[ru]-N-config if using httpd >=2.1 + APR_CONFIG=`$APXS -q APR_CONFIG 2>/dev/null || + echo $APR_BINDIR/apr-config` + APU_CONFIG=`$APXS -q APU_CONFIG 2>/dev/null || + echo $APU_BINDIR/apu-config` + + APR_CFLAGS="`$APR_CONFIG --cppflags --includes`" + APU_CFLAGS="`$APU_CONFIG --includes`" for flag in $APXS_CFLAGS; do case $flag in @@ -49,7 +55,7 @@ esac done - APACHE_CFLAGS="$APACHE_CPPFLAGS -I$APXS_INCLUDEDIR $APU_INCLUDEDIR $APR_INCLUDEDIR" + APACHE_CFLAGS="$APACHE_CPPFLAGS -I$APXS_INCLUDEDIR $APR_CFLAGS $APU_CFLAGS" # Test that we're trying to configure with apache 2.x PHP_AP_EXTRACT_VERSION($APXS_HTTPD) Index: sapi/apache2handler/config.m4 =================================================================== RCS file: /repository/php-src/sapi/apache2handler/config.m4,v retrieving revision 1.9 diff -u -r1.9 config.m4 --- sapi/apache2handler/config.m4 21 Oct 2003 11:48:31 -0000 1.9 +++ sapi/apache2handler/config.m4 23 Aug 2004 07:14:35 -0000 @@ -39,8 +39,14 @@ APU_BINDIR=`$APXS -q APU_BINDIR` APR_BINDIR=`$APXS -q APR_BINDIR` - APU_INCLUDEDIR="`$APU_BINDIR/apu-config --includes`" - APR_INCLUDEDIR="`$APR_BINDIR/apr-config --includes`" + # Pick up ap[ru]-N-config if using httpd >=2.1 + APR_CONFIG=`$APXS -q APR_CONFIG 2>/dev/null || + echo $APR_BINDIR/apr-config` + APU_CONFIG=`$APXS -q APU_CONFIG 2>/dev/null || + echo $APU_BINDIR/apu-config` + + APR_CFLAGS="`$APR_CONFIG --cppflags --includes`" + APU_CFLAGS="`$APU_CONFIG --includes`" for flag in $APXS_CFLAGS; do case $flag in @@ -48,7 +54,7 @@ esac done - APACHE_CFLAGS="$APACHE_CPPFLAGS -I$APXS_INCLUDEDIR $APU_INCLUDEDIR $APR_INCLUDEDIR" + APACHE_CFLAGS="$APACHE_CPPFLAGS -I$APXS_INCLUDEDIR $APR_CFLAGS $APU_CFLAGS" # Test that we're trying to configure with apache 2.x PHP_AP_EXTRACT_VERSION($APXS_HTTPD)