Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122834
Content-Type: multipart/alternative;
 boundary="------------mUHB462X2WWQSC26XD0qAXps"
Message-ID: <31f7de10-a2dd-489e-bc2f-66987dc832aa@scriptfusion.com>
Date: Sun, 31 Mar 2024 11:31:05 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: [PHP-DEV] First time contributor (DateTime::setDate PR)
To: internals@lists.php.net
Content-Language: en-GB
From: bilge@scriptfusion.com (Bilge)

This is a multi-part message in MIME format.
--------------mUHB462X2WWQSC26XD0qAXps
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Internals,

I created my first php-src PR 
<https://github.com/php/php-src/pull/13845> yesterday and anticipate I 
may have to write an RFC for it. I created a wiki account under the 
handle, "bilge", and the howto <https://wiki.php.net/rfc/howto> told me 
to request RFC karma here.

About the PR: I sometimes find it would be useful to only update part of 
the date. The PR makes all parameters to DateTime(Immutable)::setDate 
<https://www.php.net/manual/en/datetimeimmutable.setdate.php> optional 
in a backwards-compatible manner such that we can elect to update only 
the day, month, year or any combination of the three (thanks, in part, 
to named parameters). Without this modification, we must always specify 
all of the day, month and year parameters to change the date.

To change just one part of the date, StackOverflow users have found 
various novel 
<https://stackoverflow.com/questions/60415815/setting-just-the-year-with-php-datetime> 
ways 
<https://stackoverflow.com/questions/18176794/adjust-a-php-date-to-the-current-year> 
to work around setDate()'s current limitation, which generally involves 
calling format() twice, to isolate the specific date parts that should 
remain constant, and feeding them back into setDate() so they are 
effectively unchanged. All this leads me to wonder why we can't just 
call setDate() with only the parameters we want to change. This is 
particularly useful when generating a collection of dates that only 
differ in one aspect (year, day) and/or when working in a templating 
environment, such as Twig, where doing all the format calls results in 
multiple statements and logic overhead that we should like to avoid in 
templating contexts.

Looking forward to hearing your thoughts.

Cheers,
Bilge

--------------mUHB462X2WWQSC26XD0qAXps
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi Internals,</p>
    <p>I created my first <a
        href="https://github.com/php/php-src/pull/13845"
        moz-do-not-send="true">php-src PR</a> yesterday and anticipate I
      may have to write an RFC for it. I created a wiki account under
      the handle, "bilge", and the <a
        href="https://wiki.php.net/rfc/howto" moz-do-not-send="true">howto</a>
      told me to request RFC karma here.</p>
    <p>About the PR: I sometimes find it would be useful to only update
      part of the date. The PR makes all parameters to <a
href="https://www.php.net/manual/en/datetimeimmutable.setdate.php"
        moz-do-not-send="true">DateTime(Immutable)::setDate</a> optional
      in a backwards-compatible manner such that we can elect to update
      only the day, month, year or any combination of the three (thanks,
      in part, to named parameters). Without this modification, we must
      always specify all of the day, month and year parameters to change
      the date.</p>
    <p>To change just one part of the date, StackOverflow users have
      found various <a
href="https://stackoverflow.com/questions/60415815/setting-just-the-year-with-php-datetime"
        moz-do-not-send="true">novel</a> <a
href="https://stackoverflow.com/questions/18176794/adjust-a-php-date-to-the-current-year"
        moz-do-not-send="true">ways</a> to work around <font
        face="monospace">setDate()</font>'s current limitation, which
      generally involves calling <font face="monospace">format()</font>
      twice, to isolate the specific date parts that should remain
      constant, and feeding them back into <font face="monospace">setDate()</font>
      so they are effectively unchanged. All this leads me to wonder why
      we can't just call <font face="monospace">setDate()</font> with
      only the parameters we want to change. This is particularly useful
      when generating a collection of dates that only differ in one
      aspect (year, day) and/or when working in a templating
      environment, such as Twig, where doing all the format calls
      results in multiple statements and logic overhead that we should
      like to avoid in templating contexts.</p>
    <p>Looking forward to hearing your thoughts.</p>
    <p>Cheers,<br>
      Bilge<br>
    </p>
  </body>
</html>

--------------mUHB462X2WWQSC26XD0qAXps--