Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122778
Precedence: bulk
MIME-Version: 1.0
References: <CAAfnsFWRSwWAhps7V0qyso7u_y-tJEQ_-gRm8DOfBS=kUgpy9A@mail.gmail.com>
 <CAPyj-LAAXCs6z1W70O8W-tRxgqCPv0uMyZyyQiwmYEQqkuA2hQ@mail.gmail.com>
In-Reply-To: <CAPyj-LAAXCs6z1W70O8W-tRxgqCPv0uMyZyyQiwmYEQqkuA2hQ@mail.gmail.com>
Date: Wed, 27 Mar 2024 15:55:40 +0000
Message-ID: <CAEKnhAH-26GUtv-0FYCA_3rZ2R8ABRHx-TOrTGRWWOSXyCwiNg@mail.gmail.com>
Subject: Re: [PHP-DEV] GitHub milestones
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e68d9b0614a670fe"
From: bukka@php.net (Jakub Zelenka)

--000000000000e68d9b0614a670fe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Mar 27, 2024 at 3:26=E2=80=AFPM Ilija Tovilo <tovilo.ilija@gmail.co=
m> wrote:

> Hi Peter
>
> On Wed, Mar 27, 2024 at 9:44=E2=80=AFAM Peter Kokot <petk@php.net> wrote:
> >
> > I was wondering if it would be useful to add GitHub milestones for the
> PHP-8.4 and PHP-9.0 (or PHP-next or something like this)?
> > https://github.com/php/php-src/milestones
> >
> > Because some pull requests might target versions after the PHP-8.4 and
> it might be useful to have them additionally sorted to not forget about
> them. Not to tag all PRs of course but only those which are meant to go
> into some of the future branches.
>
> Milestones have already been used in the past
> (https://github.com/php/php-snilrc/milestones?state=3Dclosed
> <https://github.com/php/php-src/milestones?state=3Dclosed>), so there's
> no reason not to do the same for 8.4 and 9.0. Most likely, we just
> forgot. It's probably not documented as part of the release process.
>
>
We actually decided not to do it for 8.3 because it would be just waste of
time to set all PR's with that milestone. The thing is that PR should just
get merged when it's ready and we won't be delaying release because some
PR's in that milestone are not ready so it does not have any meaning.

I'm not really sure if there's any point to have non-draft PR's targeting
next major version because they cannot be merged to master until it is
decided the next version will be the major one. So those PR's should be
draft but it might make sense to create milestone for them to show quickly
why they are in draft.

So I don't think there is much point in adding 8.4 milestone but 9.0 might
be useful.

Regards

Jakub

--000000000000e68d9b0614a670fe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote"><div dir=3D"l=
tr" class=3D"gmail_attr">On Wed, Mar 27, 2024 at 3:26=E2=80=AFPM Ilija Tovi=
lo &lt;<a href=3D"mailto:tovilo.ilija@gmail.com">tovilo.ilija@gmail.com</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi P=
eter<br>
<br>
On Wed, Mar 27, 2024 at 9:44=E2=80=AFAM Peter Kokot &lt;<a href=3D"mailto:p=
etk@php.net" target=3D"_blank">petk@php.net</a>&gt; wrote:<br>
&gt;<br>
&gt; I was wondering if it would be useful to add GitHub milestones for the=
 PHP-8.4 and PHP-9.0 (or PHP-next or something like this)?<br>
&gt; <a href=3D"https://github.com/php/php-src/milestones" rel=3D"noreferre=
r" target=3D"_blank">https://github.com/php/php-src/milestones</a><br>
&gt;<br>
&gt; Because some pull requests might target versions after the PHP-8.4 and=
 it might be useful to have them additionally sorted to not forget about th=
em. Not to tag all PRs of course but only those which are meant to go into =
some of the future branches.<br>
<br>
Milestones have already been used in the past<br>
(<a href=3D"https://github.com/php/php-src/milestones?state=3Dclosed" rel=
=3D"noreferrer" target=3D"_blank">https://github.com/php/php-snilrc/milesto=
nes?state=3Dclosed</a>), so there&#39;s<br>
no reason not to do the same for 8.4 and 9.0. Most likely, we just<br>
forgot. It&#39;s probably not documented as part of the release process.<br=
>
<br></blockquote><div><br></div><div>We actually decided not to do it for 8=
.3 because it would be just waste of time to set all PR&#39;s with that mil=
estone. The thing is that PR should just get merged when it&#39;s ready and=
 we won&#39;t be delaying release because some PR&#39;s in that milestone a=
re not ready so it does not have any meaning.=C2=A0</div><div><br></div><di=
v>I&#39;m not really sure if there&#39;s any point to have non-draft PR&#39=
;s targeting next major version because they cannot be merged to master unt=
il it is decided the next version will be the major one. So those PR&#39;s =
should be draft but it might make sense to create milestone for them to sho=
w quickly why they are in draft.</div><div><br></div><div>So I don&#39;t th=
ink there is much point in adding 8.4 milestone but 9.0 might be useful.</d=
iv><div><br></div><div>Regards</div><div><br></div><div>Jakub</div></div></=
div>

--000000000000e68d9b0614a670fe--