Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122641
Subject: Re: [PHP-DEV] Re: [PHP-CVS] [php-src] master: Deprecate implicit
 nullable parameter types (#12959)
To: Matteo Beccati <php@beccati.com>, internals@lists.php.net
References: <ehGvnYWM4ili7mHZlnn8CekQZmR2ZyF5AbR2uBOYGHs@main.php.net>
 <93d57585-30d9-4912-9b26-0c6a699a8b9d@beccati.com>
 <54f107c7-8b44-42b7-948c-95e4e56aa072@php.net>
 <e6e55d3a-f6f8-44ea-94de-52ae53d4e8b4@beccati.com>
Cc: Sebastian Bergmann <sebastian@php.net>
Message-ID: <65F31469.7010104@adviesenzo.nl>
Date: Thu, 14 Mar 2024 16:14:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <e6e55d3a-f6f8-44ea-94de-52ae53d4e8b4@beccati.com>
Content-Type: multipart/alternative;
 boundary="------------000504010000030207080909"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------000504010000030207080909
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 14-3-2024 15:55, Matteo Beccati wrote:
> Hi Sebastian,
>
> Il 14/03/2024 14:15, Sebastian Bergmann ha scritto:
>> Am 14.03.2024 um 14:07 schrieb Matteo Beccati:
>>> In my daily CI I have several builds failing today, eg.
>>>
>>> * PHPUnit 9.6
>>
>> See https://github.com/sebastianbergmann/phpunit/issues/5719.
>
> thanks, I had a quick look in the open issues and didn't find anything.
>
> Kudos for looking into it way ahead of the actual merge of the PR to 
> master.
>
>
> Cheers


For whomever is interested:

I've already worked up sniffs for PHPCompatibility [1] to flag the 
deprecation. The sniffs should be able to help find any issues with high 
precision.

I'm waiting on an update of `git.master` on 3v4l.org [2] to validate the 
sniffs are matching the PHP native behaviour exactly.
Once I have been able to validate, the sniffs will be made publicly 
available. (hopefully in a day or two)

Smile,
Juliette

1: https://github.com/PHPCompatibility/PHPCompatibility
2: https://phpc.social/@jrf_nl/112091061544484825

--------------000504010000030207080909
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 14-3-2024 15:55, Matteo Beccati
      wrote:<br>
    </div>
    <blockquote
      cite="mid:e6e55d3a-f6f8-44ea-94de-52ae53d4e8b4@beccati.com"
      type="cite">Hi Sebastian,
      <br>
      <br>
      Il 14/03/2024 14:15, Sebastian Bergmann ha scritto:
      <br>
      <blockquote type="cite">Am 14.03.2024 um 14:07 schrieb Matteo
        Beccati:
        <br>
        <blockquote type="cite">In my daily CI I have several builds
          failing today, eg.
          <br>
          <br>
          * PHPUnit 9.6
          <br>
        </blockquote>
        <br>
        See <a class="moz-txt-link-freetext" href="https://github.com/sebastianbergmann/phpunit/issues/5719">https://github.com/sebastianbergmann/phpunit/issues/5719</a>.
        <br>
      </blockquote>
      <br>
      thanks, I had a quick look in the open issues and didn't find
      anything.
      <br>
      <br>
      Kudos for looking into it way ahead of the actual merge of the PR
      to master.
      <br>
      <br>
      <br>
      Cheers
      <br>
    </blockquote>
    <br>
    <br>
    For whomever is interested:<br>
    <br>
    I've already worked up sniffs for PHPCompatibility [1] to flag the
    deprecation. The sniffs should be able to help find any issues with
    high precision.<br>
    <br>
    I'm waiting on an update of `git.master` on 3v4l.org [2] to validate
    the sniffs are matching the PHP native behaviour exactly.<br>
    Once I have been able to validate, the sniffs will be made publicly
    available. (hopefully in a day or two)<br>
    <br>
    Smile,<br>
    Juliette<br>
    <br>
    1: <a class="moz-txt-link-freetext" href="https://github.com/PHPCompatibility/PHPCompatibility">https://github.com/PHPCompatibility/PHPCompatibility</a><br>
    2: <a class="moz-txt-link-freetext" href="https://phpc.social/@jrf_nl/112091061544484825">https://phpc.social/@jrf_nl/112091061544484825</a><br>
  </body>
</html>

--------------000504010000030207080909--