Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122602
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-251-g8332da0bf6-fm-20240305.001-g8332da0b
Precedence: bulk
MIME-Version: 1.0
Message-ID: <290788fe-57cc-42e1-bc74-85a768cdf63d@app.fastmail.com>
In-Reply-To: 
 <EIeXRgEfkctuEBHawJxwjtswKsCwLhmxtWCgMpPZnfr3aj2BYERIPUU_lYIRUBDubfWjxXJfzLIDZZh0EK5NqaR2Y05Tya1-ECcvZQl5DGc=@gpb.moe>
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
 <07407c20-09ea-4bb9-a5cf-3af41b9234ee@mabe.berlin>
 <8a96a374-eaf8-4ac6-b45c-61d2a0c9652f@mabe.berlin>
 <73b032ec-b41a-4b96-8254-f0b68abf87f2@app.fastmail.com>
 <EIeXRgEfkctuEBHawJxwjtswKsCwLhmxtWCgMpPZnfr3aj2BYERIPUU_lYIRUBDubfWjxXJfzLIDZZh0EK5NqaR2Y05Tya1-ECcvZQl5DGc=@gpb.moe>
Date: Sun, 10 Mar 2024 10:52:06 -0500
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, Mar 10, 2024, at 10:31 AM, Gina P. Banyard wrote:
> On Saturday, 9 March 2024 at 16:00, Larry Garfield 
> <larry@garfieldtech.com> wrote:
>
>> I am still opposed to this. Logically, ceil/float/round should be returning ints, not floats. Only returning ints if it was given an int is, er, kinda pointless, as you'll just get back the value you passed in. (Because it's already rounded/floored, etc.) So this doesn't get us any new type safety, but does make the return type less consistent than it is today. That's a step backwards.
>> 
>> If there's some math reason that we cannot have those functions return int (someone mentioned there was, but I don't really understand it and the RFC does not explain it at all), then we should at least keep consistency in the return type. "Sometimes I have to cast the return value before I can actually use it in the obvious way, sometimes I don't" is not a good situation.
>> 
>> --Larry Garfield
>
> There are plenty of values that are exactly representable as floating 
> point numbers but not as integers.
>
> One short example:
>
> $v = 1e10 + 0.6;
> var_dump($v);
> var_dump(round($v));
>
> Gives you accurate precision and proper rounding behaviour.
>
> 1e10 *cannot* be represented as an integer.
>
> So round *must* be able to return a float.
>
> Best regards,
>
> Gina P. Banyard

Please include some version of this in the RFC.  Especially if it can be even more detailed.

--Larry Garfield