Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122595
Feedback-ID: ia2404087:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-251-g8332da0bf6-fm-20240305.001-g8332da0b
Precedence: bulk
MIME-Version: 1.0
Message-ID: <f4b95584-7aac-4a49-a668-df5a92dfc990@app.fastmail.com>
In-Reply-To: <73b032ec-b41a-4b96-8254-f0b68abf87f2@app.fastmail.com>
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
 <07407c20-09ea-4bb9-a5cf-3af41b9234ee@mabe.berlin>
 <8a96a374-eaf8-4ac6-b45c-61d2a0c9652f@mabe.berlin>
 <73b032ec-b41a-4b96-8254-f0b68abf87f2@app.fastmail.com>
Date: Sat, 09 Mar 2024 11:29:10 -0800
To: "Larry Garfield" <larry@garfieldtech.com>,
 "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
Content-Type: text/plain
From: jimw@trainedmonkey.com ("Jim Winstead")

On Sat, Mar 9, 2024, at 8:00 AM, Larry Garfield wrote:
]> If there's some math reason that we cannot have those functions return 
> int (someone mentioned there was, but I don't really understand it and 
> the RFC does not explain it at all), then we should at least keep 
> consistency in the return type.  "Sometimes I have to cast the return 
> value before I can actually use it in the obvious way, sometimes I 
> don't" is not a good situation.

The round() function has to be able to return float because has an optional precision parameter. So round(3.14, 1) returns 3.1.

I agree that there doesn't appear to be much of a reason that ceil() and floor() should be returning float. The documentation for ceil() says: The return value of ceil() is still of type float as the value range of float is usually bigger than that of int.

Jim