Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122594
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-251-g8332da0bf6-fm-20240305.001-g8332da0b
Precedence: bulk
MIME-Version: 1.0
Message-ID: <73b032ec-b41a-4b96-8254-f0b68abf87f2@app.fastmail.com>
In-Reply-To: <8a96a374-eaf8-4ac6-b45c-61d2a0c9652f@mabe.berlin>
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
 <07407c20-09ea-4bb9-a5cf-3af41b9234ee@mabe.berlin>
 <8a96a374-eaf8-4ac6-b45c-61d2a0c9652f@mabe.berlin>
Date: Sat, 09 Mar 2024 10:00:21 -0600
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Sat, Mar 9, 2024, at 1:01 AM, Marc wrote:
> Hi internals,
>
> Just want to resent this note about the updated RFC as there where no 
> comments last time and I'm unsure if this was due to mailing list issues.
>
> I now have updated the RFC to allow to opt-in to new behavior on PHP 8.4 
> and be able to opt-out to previous behavior in PHP 9.0 via new parameter 
> "force_float".
>
> Also the deprecation has been removed as nobody liked it.
>
> If no further comments arrive I'll like to start voting next week Friday.
>
> Best regards,
> Marc

I am still opposed to this.  Logically, ceil/float/round should be returning ints, not floats.  Only returning ints if it was given an int is, er, kinda pointless, as you'll just get back the value you passed in.  (Because it's already rounded/floored, etc.)  So this doesn't get us any new type safety, but does make the return type less consistent than it is today.  That's a step backwards.

If there's some math reason that we cannot have those functions return int (someone mentioned there was, but I don't really understand it and the RFC does not explain it at all), then we should at least keep consistency in the return type.  "Sometimes I have to cast the return value before I can actually use it in the obvious way, sometimes I don't" is not a good situation.

--Larry Garfield