Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122571
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-208-g3f1d79aedb-fm-20240301.002-g3f1d79ae
Precedence: bulk
MIME-Version: 1.0
Message-ID: <51122d7e-f218-4243-bbb8-dd59de2165b4@app.fastmail.com>
In-Reply-To: 
 <CAEPPVa2SNQS_Mggq50eLUSrNaabTnQTgHQ3Y0bjqCa3FgAP4Ew@mail.gmail.com>
References: 
 <CAEPPVa2JLAbXh0hVY72srY2FAVywr=s7baafHCF_ggqmyVgAyA@mail.gmail.com>
 <f94eb6cc-007a-4578-83cf-a4dccbec40a4@gmail.com>
 <CAEPPVa2SNQS_Mggq50eLUSrNaabTnQTgHQ3Y0bjqCa3FgAP4Ew@mail.gmail.com>
Date: Tue, 05 Mar 2024 17:40:26 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [Discussion] grapheme cluster for str_split function
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Mar 5, 2024, at 7:25 AM, youkidearitai wrote:
> 2024=E5=B9=B43=E6=9C=885=E6=97=A5(=E7=81=AB) 5:52 Niels Dossche <dossc=
he.niels@gmail.com>:
>>
>> Hi Yuya
>>
>> This sounds useful.
>>
>> I do have a question about the function signature:
>> function grapheme_str_split(string $string, int $length =3D 1): array=
 {}
>>
>> This always returns an array.
>> However, looking at your PR it seems you return NULL on failure, but =
the return type in the signature isn't nullable.
>> Also, from a quick look, it seems other functions return false instea=
d of null on failure. So perhaps the return type should be array|false.
>>
>> What do you think? :)
>>
>> Kind regards
>> Niels
>>
>> On 03/03/2024 00:21, youkidearitai wrote:
>> > Hi, Internals
>> >
>> > I noticed PHP does not have grapheme cluster for str_split function=
.,
>> > Until now, you had to use the PCRE function's \X.
>> >
>> > Therefore, I try create `grapheme_str_split` function.
>> > https://github.com/php/php-src/pull/13580
>> > It is possible to convert array per emoji and variation selectors u=
sing ICU.
>> >
>> > If it's fine, I'll create an RFC.
>> >
>> > Regards
>> > Yuya
>> >
>
> Hi, Niels
>
> Thank you for your comment.
> Indeed, returns false is make sense.
>
> Therefore, I changed to returns false when invalid UTF-8 strings.
>
> Regards
> Yuya

Many legacy functions return false on error, but that is widely regarded=
 as bad design.  Please do not continue bad design.

Right now, the best "standard" error handling mechanism available is exc=
eptions.  false (or null) can very easily lead to incorrectly using that=
 value as though it were valid, when it's not, which will sometimes caus=
e a fatal error and sometimes cause a security leak. =20

If the input value cannot be logically processed, that's an exception.  =
(Or Error, perhaps.)

--Larry Garfield