Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122561
Precedence: bulk
MIME-Version: 1.0
References: <CAEPPVa2JLAbXh0hVY72srY2FAVywr=s7baafHCF_ggqmyVgAyA@mail.gmail.com>
 <f94eb6cc-007a-4578-83cf-a4dccbec40a4@gmail.com>
In-Reply-To: <f94eb6cc-007a-4578-83cf-a4dccbec40a4@gmail.com>
Date: Tue, 5 Mar 2024 16:25:43 +0900
Message-ID: <CAEPPVa2SNQS_Mggq50eLUSrNaabTnQTgHQ3Y0bjqCa3FgAP4Ew@mail.gmail.com>
Subject: Re: [PHP-DEV] [Discussion] grapheme cluster for str_split function
To: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: youkidearitai@gmail.com (youkidearitai)

2024=E5=B9=B43=E6=9C=885=E6=97=A5(=E7=81=AB) 5:52 Niels Dossche <dossche.ni=
els@gmail.com>:
>
> Hi Yuya
>
> This sounds useful.
>
> I do have a question about the function signature:
> function grapheme_str_split(string $string, int $length =3D 1): array {}
>
> This always returns an array.
> However, looking at your PR it seems you return NULL on failure, but the =
return type in the signature isn't nullable.
> Also, from a quick look, it seems other functions return false instead of=
 null on failure. So perhaps the return type should be array|false.
>
> What do you think? :)
>
> Kind regards
> Niels
>
> On 03/03/2024 00:21, youkidearitai wrote:
> > Hi, Internals
> >
> > I noticed PHP does not have grapheme cluster for str_split function.,
> > Until now, you had to use the PCRE function's \X.
> >
> > Therefore, I try create `grapheme_str_split` function.
> > https://github.com/php/php-src/pull/13580
> > It is possible to convert array per emoji and variation selectors using=
 ICU.
> >
> > If it's fine, I'll create an RFC.
> >
> > Regards
> > Yuya
> >

Hi, Niels

Thank you for your comment.
Indeed, returns false is make sense.

Therefore, I changed to returns false when invalid UTF-8 strings.

Regards
Yuya

--=20
---------------------------
Yuya Hamada (tekimen)
- https://tekitoh-memdhoi.info
- https://github.com/youkidearitai
-----------------------------