Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122553
Message-ID: <f94eb6cc-007a-4578-83cf-a4dccbec40a4@gmail.com>
Date: Mon, 4 Mar 2024 20:17:41 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [Discussion] grapheme cluster for str_split function
To: internals@lists.php.net
References: <CAEPPVa2JLAbXh0hVY72srY2FAVywr=s7baafHCF_ggqmyVgAyA@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAEPPVa2JLAbXh0hVY72srY2FAVywr=s7baafHCF_ggqmyVgAyA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
From: dossche.niels@gmail.com (Niels Dossche)

Hi Yuya

This sounds useful.

I do have a question about the function signature:
function grapheme_str_split(string $string, int $length = 1): array {}

This always returns an array.
However, looking at your PR it seems you return NULL on failure, but the return type in the signature isn't nullable.
Also, from a quick look, it seems other functions return false instead of null on failure. So perhaps the return type should be array|false.

What do you think? :)

Kind regards
Niels

On 03/03/2024 00:21, youkidearitai wrote:
> Hi, Internals
> 
> I noticed PHP does not have grapheme cluster for str_split function.,
> Until now, you had to use the PCRE function's \X.
> 
> Therefore, I try create `grapheme_str_split` function.
> https://github.com/php/php-src/pull/13580
> It is possible to convert array per emoji and variation selectors using ICU.
> 
> If it's fine, I'll create an RFC.
> 
> Regards
> Yuya
>