Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122535
Precedence: bulk
MIME-Version: 1.0
References: <CAK7R4azyh4Yi6NjYFLwD_9BMeH9TD8YmTxQ46cn96Z7cCVy-eA@mail.gmail.com>
 <A813DBD2-219F-404C-AB67-AD5ECA0124C2@gmail.com> <CAJmy8YHOCkvEec1WQbjzAomRwmU3H3+wqfoz4UVXcMmE-kb8uw@mail.gmail.com>
In-Reply-To: <CAJmy8YHOCkvEec1WQbjzAomRwmU3H3+wqfoz4UVXcMmE-kb8uw@mail.gmail.com>
Date: Thu, 29 Feb 2024 16:12:01 +0700
Message-ID: <CANLbj-r3PxQ0iavMemgR0jq7=Gf8KGSn8jZcnzmxL6VP0vEQnA@mail.gmail.com>
Subject: Re: [PHP-DEV] int|float for sleep? sleep(0.1) => sleep 0.1 seconds
To: Hans Henrik Bergan <divinity76@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ac65b2061281a7ae"
From: ayesh@php.watch (Ayesh Karunaratne)

--000000000000ac65b2061281a7ae
Content-Type: text/plain; charset="UTF-8"

>
> Made a RFC draft: https://wiki.php.net/rfc/sleep_function_float_support
>
> First time, so I'm not surprised if there are some mistakes there.
>
> Feedback is very welcome.
>

Hi Hans,
The RFC looks great, and I am personally positive to see these proposed
changes implemented in PHP.

One suggestion I have is to simplify the six votes to three, each with
three options:

 - Disagree the proposal
 - Agree to implement in PHP 8.4
 - Agree to implement in PHP 9.0

I think it's also helpful if the PR link was added to the top of the RFC,
ideally next to the "First Published at". Most RFCs also remove the
sections that don't apply to them (such as Future Scope section).

That said, thanks for making this, it's something I'd like to see in PHP as
well.

--000000000000ac65b2061281a7ae
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote"><blockquote class=3D"gmai=
l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left=
:1ex"><div dir=3D"auto"><div dir=3D"auto"><div dir=3D"auto">Made a RFC draf=
t: <a href=3D"https://wiki.php.net/rfc/sleep_function_float_support" rel=3D=
"noreferrer noreferrer" target=3D"_blank">https://wiki.php.net/rfc/sleep_fu=
nction_float_support</a></div><div dir=3D"auto"><br></div><div dir=3D"auto"=
>First time, so I&#39;m not surprised if there are some mistakes there.</di=
v><div dir=3D"auto"><br></div><div dir=3D"auto">Feedback is very welcome.</=
div></div></div></blockquote></div></div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">Hi Hans,</div><div dir=3D"auto">The RFC looks great, and I am p=
ersonally positive to see these proposed changes implemented in PHP.=C2=A0<=
/div><div dir=3D"auto"><br></div><div dir=3D"auto">One suggestion I have is=
 to simplify the six votes to three, each with three options:</div><div dir=
=3D"auto"><br></div><div dir=3D"auto">=C2=A0- Disagree the proposal</div><d=
iv dir=3D"auto">=C2=A0- Agree to implement in PHP 8.4</div><div dir=3D"auto=
">=C2=A0- Agree to implement in PHP 9.0</div><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">I think it&#39;s also helpful if the PR link was added to t=
he top of the RFC, ideally next to the &quot;First Published at&quot;. Most=
 RFCs also remove the sections that don&#39;t apply to them (such as Future=
 Scope section).=C2=A0</div><div dir=3D"auto"><br></div><div dir=3D"auto">T=
hat said, thanks for making this, it&#39;s something I&#39;d like to see in=
 PHP as well.=C2=A0</div><div dir=3D"auto"><br></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=3D"gmail_quo=
te"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-lef=
t:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--000000000000ac65b2061281a7ae--