Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122486
Subject: Re: [PHP-DEV] [Pre-RFC] Convert exit (and die) from language
 constructs to functions
To: "Gina P. Banyard" <internals@gpb.moe>
References: <dML_nemsGsapovq472mSesuTIKSnJs05IBe1me9cfqf6CALh2GkPjtQ5xJ5OYLyEDAaKYEL-TTouCTYlHlwHQFeMfleMoprZSUZrGRlPnpY=@gpb.moe>
 <65D94D20.6020702@adviesenzo.nl>
 <j6DvqHCOyKyOFZ4QdDbYYh7sctrXQVwBGlqRYhvZIUbSjLhKT5xQdn_MZDX9ls44VTw5M925zHZcl9HIj3igqP7O0tO2EDf9f2P38OAQ_p0=@gpb.moe>
Cc: internals@lists.php.net
Message-ID: <65D97FC1.2060203@adviesenzo.nl>
Date: Sat, 24 Feb 2024 06:33:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <j6DvqHCOyKyOFZ4QdDbYYh7sctrXQVwBGlqRYhvZIUbSjLhKT5xQdn_MZDX9ls44VTw5M925zHZcl9HIj3igqP7O0tO2EDf9f2P38OAQ_p0=@gpb.moe>
Content-Type: multipart/alternative;
 boundary="------------080202020006060304010802"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------080202020006060304010802
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit



On 24-2-2024 3:47, Gina P. Banyard wrote:
>
>
> On Saturday, 24 February 2024 at 01:57, Juliette Reinders Folmer 
> <php-internals_nospam@adviesenzo.nl> wrote:
>
>> Hi Gina,
>>
>> I'm not sure a pet-peeve is a good motivation for creating an (I 
>> expect large) breaking change.
>>
>> The upgrade path, I suppose, would be updating calls to `die`/`exit` 
>> to always have parentheses ? Or alternatively changing those calls to 
>> new throw expressions ?
>>
>> While that shouldn't be that huge a problem for real codebases (and 
>> would be auto-fixable for adding the parentheses), the bigger problem 
>> I see is the huge amount of teaching materials, tutorials and blog 
>> posts using the versions without parentheses which will now all be 
>> invalidated. I think the pain and confusion that will cause for a 
>> change like this, will linger for years and years.
>>
>> Smile,
>> Juliette
>>
>
> I didn't actually know one could do exit;
> But like I said, it is extremely easy to support, and the current PR 
> does support it by hooking into the undefined constant code in the engine.
> I don't have strong opinions about removing support for this.
> However, I do have strong opinions about changing the type juggling 
> semantics of exit() to be the usual ones, because the current one is 
> just confusing.
> I am also not sure what would make this a large breaking change, as 
> changing this from a language construct to a function provides us with 
> more capabilities.
>

Ah, I think I missed the part about the syntax both with and without 
parentheses still being supported, with the "with parentheses" mapping 
to a function call and the "without parentheses" mapping to a 
case-insensitive constant.

In that case, I don't see a BC-break and I would regard this as an 
"under the hood" change with only a very subtle, minimal impact (the 
type checking part if a param is passed).

I do wonder what the documentation would look like as it would leave it 
as a function, but one with a special status, in that there is a native 
constant of the same name which will enforce the same behaviour.

Smile,
Juliette




--------------080202020006060304010802
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <br>
    <div class="moz-cite-prefix">On 24-2-2024 3:47, Gina P. Banyard
      wrote:<br>
    </div>
    <blockquote
cite="mid:j6DvqHCOyKyOFZ4QdDbYYh7sctrXQVwBGlqRYhvZIUbSjLhKT5xQdn_MZDX9ls44VTw5M925zHZcl9HIj3igqP7O0tO2EDf9f2P38OAQ_p0=@gpb.moe"
      type="cite">
      <div class="protonmail_signature_block" style="font-family: Arial,
        sans-serif; font-size: 14px;">
        <div class="protonmail_signature_block-user">
          <div style="font-family: Arial, sans-serif; font-size: 14px;
            color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"><br>
          </div>
        </div>
        <div class="protonmail_signature_block-proton
          protonmail_signature_block-empty"> </div>
      </div>
      <div style="font-family: Arial, sans-serif; font-size: 14px;"><br>
      </div>
      <div class="protonmail_quote"> On Saturday, 24 February 2024 at
        01:57, Juliette Reinders Folmer
        <a class="moz-txt-link-rfc2396E" href="mailto:php-internals_nospam@adviesenzo.nl">&lt;php-internals_nospam@adviesenzo.nl&gt;</a> wrote:<br>
        <div><br>
        </div>
        <blockquote class="protonmail_quote" type="cite"> Hi Gina,<br>
          <br>
          I'm not sure a pet-peeve is a good motivation for creating an
          (I expect large) breaking change.<br>
          <br>
          The upgrade path, I suppose, would be updating calls to
          `die`/`exit` to always have parentheses ? Or alternatively
          changing those calls to new throw expressions ?<br>
          <br>
          While that shouldn't be that huge a problem for real codebases
          (and would be auto-fixable for adding the parentheses), the
          bigger problem I see is the huge amount of teaching materials,
          tutorials and blog posts using the versions without
          parentheses which will now all be invalidated. I think the
          pain and confusion that will cause for a change like this,
          will linger for years and years.<br>
          <br>
          Smile,<br>
          Juliette<br>
          <br>
        </blockquote>
        <span style="font-family:Arial, sans-serif"></span>
        <div style="font-family:Arial, sans-serif"><br>
        </div>
        <div style="font-family:Arial, sans-serif">I didn't actually
          know one could do exit;</div>
        <div style="font-family:Arial, sans-serif">But like I said, it
          is extremely easy to support, and the current PR does support
          it by hooking into the undefined constant code in the engine.</div>
        <div style="font-family:Arial, sans-serif">I don't have strong
          opinions about removing support for this.</div>
        <div style="font-family:Arial, sans-serif">However, I do have
          strong opinions about changing the type juggling semantics of
          exit() to be the usual ones, because the current one is just
          confusing.</div>
        <div style="font-family:Arial, sans-serif">I am also not sure
          what would make this a large breaking change, as changing this
          from a language construct to a function provides us with more
          capabilities.<br>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
    Ah, I think I missed the part about the syntax both with and without
    parentheses still being supported, with the "with parentheses"
    mapping to a function call and the "without parentheses" mapping to
    a case-insensitive constant.<br>
    <br>
    In that case, I don't see a BC-break and I would regard this as an
    "under the hood" change with only a very subtle, minimal impact (the
    type checking part if a param is passed).<br>
    <br>
    I do wonder what the documentation would look like as it would leave
    it as a function, but one with a special status, in that there is a
    native constant of the same name which will enforce the same
    behaviour.<br>
    <br>
    Smile,<br>
    Juliette<br>
    <br>
    <br>
    <br>
  </body>
</html>

--------------080202020006060304010802--