Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122439
Date: Tue, 20 Feb 2024 08:58:14 +0000
To: internals@lists.php.net, Marc Bennewitz <marc@mabe.berlin>
Subject: Re: [PHP-DEV] Requesting RFC karma
User-Agent: K-9 Mail for Android
In-Reply-To: <176d0694-8b9b-4aa2-abea-9bfe8225b713@mabe.berlin>
References: <CAK7R4axbuhFpsKfkk=j2-eZ6Te8vqvEaCY3wHE7VwCzkVEcteQ@mail.gmail.com> <176d0694-8b9b-4aa2-abea-9bfe8225b713@mabe.berlin>
Message-ID: <EA0B4725-BAF3-447A-902B-CD571100504B@php.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: derick@php.net (Derick Rethans)

On 20 February 2024 08:41:19 GMT, Marc Bennewitz <marc@mabe=2Eberlin> wrote=
:
>Hi Hans,
>
>On 16=2E02=2E24 13:05, Hans Henrik Bergan wrote:
>> My name is "Hans Henrik Bergan", usually go by the nickname
>> "divinity76", I've contributed to OSS (including PHP) for years, and
>> am currently involved in 3 things that might require an RFC, and
>> requesting RFC karma for wiki account "divinity76"=2E
>>=20
>> 3/3: int|float for DateTime::setTimestamp, setTimestamp(0=2E123456) =3D=
>
>> 1970-01-01 00:00:00=2E123456 : https://github=2Ecom/php/php-src/pull/13=
383
>
>Actually I also want to work on this if I find time =2E=2E=2E but as this=
 is a BC break I think it makes sense to revisit DateTime (and friends) to =
bundle BC breaks to a single PHP version - probably PHP 9 and more sure the=
re is a way for users to make it work in PHP (7+)8+9=2E
>
>Personal and incomplete list I think needs improvements:
>
>* allow float for `setTimestamp`
>* option to return timestamp as float to simplify passing it to JS
>* Missing getter/setter for most of the date/time parts like `get/setSeco=
nd`, `get/setHour` etc=2E
>=C2=A0 * For now I only added `get/setMicroseconds` together with `create=
FromTimestamp` because `DateTime::createFromTimestamp(123456789)->setMicros=
econds(123987)`
>=C2=A0 * After thinking about naming - I think this should be renamed to =
singular =F0=9F=98=AC
>* Add missing methods to DateTimeInterface
>* Allow userland implements DateTimeInterface
>=C2=A0 * Define how `createFromInterface` behaves on userland implementat=
ions
>* fixing ISO 8601 format
>* fixing some return type definitions from self to static
>* strict mode
>=C2=A0 * `DateTime::createFromFormat('Y-m-d', '2023-02-29')`
>=C2=A0 * `DateTime::createFromFormat('Y-m-d H:i', '2024-03-31 02:30', new=
 DateTimeZone('Europe/Berlin'))`
>* Missing current microseconds on `createFromFormat` but other non define=
d parts needs to be explicitly reset using `|!`
>* leap seconds support on UTC TZ
>=C2=A0 * As of leap seconds =2E=2E=2E wouldn't it be better to default to=
 +00:00 instead of UTC ?
>* Support nanoseconds
>
>
>I'm for sure not able to work on all these points and that's why I only s=
tarted very small close to no BC improvements without RFC=2E
>
>
>Marc
>

IMO, doing tweaks to this base functionality isn't the way forwards=2E I'v=
e been having on and off conversations with Florian over the last couple of=
 months to see if we can design a better higher level API instead of patchi=
ng the nits=2E

cheers
Derick