Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:122432 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id B98621ACEBF for ; Sun, 18 Feb 2024 18:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1708280358; bh=TKdg3wR98Z4+eQ+2/DsjAgmJkDCcBwGzFSVPFOd3tcQ=; h=References:In-Reply-To:From:Date:Subject:To:From; b=bHI6b+y2RuocqiwQwjIabwfAiNZSI09YESi83UB8uNIEupTLT1r1wigfi60oPEF51 eP8YhLUVN/4rXLVk3AUJx5XQp6l8OdSwt80AFLh6HP4Uz5gSj647czN0UlZxXyIu9T S4v7piLNKf/hpXTnNqIjKmvNgH+huJTufU7m/+dZ5inYiAgmUtxa3WhsWvfu11EdQ4 gx/n0Sp2ro1kJwBrrHFQFk5tWyVUtqbZ2JuKaSZH8QeYah6aZ3nAXoBJ7wEd5fVkiB fJl0x/UTRZxUA9JopLRABmXaKdr1786nhlDomPTU3lgqHQNdJ5h+eq9xHf4ytRHbFL eV8ahcVt4lYdg== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id C094718096B for ; Sun, 18 Feb 2024 18:19:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 18 Feb 2024 10:19:17 -0800 (PST) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-42a35c720b8so15301291cf.3 for ; Sun, 18 Feb 2024 10:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708280353; x=1708885153; darn=lists.php.net; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TKdg3wR98Z4+eQ+2/DsjAgmJkDCcBwGzFSVPFOd3tcQ=; b=P7vwnX9BdFxjaivnb5uM/ttc93zlV5OK6m4qdLt9VWj7A3HVJZ1szVINRj17CLW+EL BQb7lTEZObXEwoCN2ZZ83ywbm0VFwEvDQJxPMi6qgFVdrA1WkFzzOvw9QCUjkWocNGzq vWKnn9qe9hTYf0I+wnIcXDIC5ILLRu6l03ubx3SEp/XOg3zhS4GPvExCJQ48gmxgg6/0 bt+UwKMP4TkmxKOym1p+UfsjQD8hO7XIgImZ1yR9NLt+PeMPRlLYBE8W7t0u0nlTqwBw qQmlawfseM84fpn6ATM+Ldhu5MgPhrLQ2TEpkiCQoYZE5m6tLTLf9RiVwQsNxYeJR5xg Hq7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708280353; x=1708885153; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TKdg3wR98Z4+eQ+2/DsjAgmJkDCcBwGzFSVPFOd3tcQ=; b=SPl3jKTsxEnOZ3X9FC71yMMLUs3QFbMw4l9pMIiev6xIiOEFc0aSM1StrEDwfbW4qA YOsWebQaPI2an8fqow+IIGKFlSiXs7GOoqTL2EIDV/S5sOG+cyGWjfowJo07cX0CEk0g kPE9JQzhToxmybH69Pf8xbCJfJYaR2e1nHex0x4bIA8ILQhggS41YRdHOvXHgKEJDR9X 85A3oxB0IEH02/XiBNcxISFgkfVt9e0WitEYnuQN/07MMu+I4jDVqulH/ZNT8TK3lnbE MEi7WVV4nIOO8rqDQsMPLniI/Ai/dnUDYKe1085a3ODnjFLzagUW4pP+KKoHMALpNNxL L+Vw== X-Gm-Message-State: AOJu0Yx89UQgYu0oEed1lSKkKZXIxCCo9ki/jb/eSYAcruocZHr2/625 l/llaY0We3/e0WrhurBnkgcURTPZiUhjt+Dg78jsLzPlACmz3b7B3Hz1fnakpRv+QK67rpRu6KQ Qpe3ca5BLH555xBJ/DQrMnN0Eo+AzeWCyVq8BAA== X-Google-Smtp-Source: AGHT+IFPzfcSYLwmUqnzL9KeHyBMZTloErAVnGErh35w1Vr9eGm1dapOheQq5rJUBIivpwoYX1uCrKZBt65YkC4R8nw= X-Received: by 2002:a05:6214:328e:b0:68f:5ab1:a133 with SMTP id mu14-20020a056214328e00b0068f5ab1a133mr4205945qvb.48.1708280353239; Sun, 18 Feb 2024 10:19:13 -0800 (PST) Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net MIME-Version: 1.0 References: In-Reply-To: Date: Sun, 18 Feb 2024 19:19:02 +0100 Message-ID: Subject: Re: [PHP-DEV] automatic formatting checks for pull requests? To: PHP Internals List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable From: tovilo.ilija@gmail.com (Ilija Tovilo) On Sun, Feb 18, 2024 at 4:11=E2=80=AFPM Gina P. Banyard = wrote: > > On Saturday, 17 February 2024 at 22:18, Ilija Tovilo wrote: > > > * The new code style should be applied only to newly added sections or > > changed code, not entire files. Otherwise, we'll have many changes in > > large files, with endless merge conflicts when merging up from lower > > branches. > > Surely the best way is to apply the formatting tool on all branches that = are supported (even in security support). > Have them be merged upwards, and then add the revisions of the commits to= a .git-blame-ignore-revs file so that git blame doesn't care about them. > > This should resolve the issue of making future merges difficult. Presumably, this would lead to merge conflicts in every open pull request. Maybe a resolution strategy could be automated, not ideal nonetheless. Additionally, given that the PR has discovered a clang-format bug that changes behavior (https://github.com/php/php-src/pull/13417#issuecomment-1950920114), I'd be wary of applying the formatting blindly to our stable branches.