Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122429
Date: Sun, 18 Feb 2024 15:11:27 +0000
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Subject: Re: [PHP-DEV] automatic formatting checks for pull requests?
Message-ID: <MQh04VMLKOq4WGBo47OlPczt0Um3L_ahXHppKt1eUHGJ3hkk-IRHxYPqQza1_054qJyYAJr2aky4rWEJ2WZ5rw6ffOTld6jgOBdly0bQ1kQ=@gpb.moe>
In-Reply-To: <CAPyj-LA8eDWBGqYcw7S0DTRZXN1=6HFOncwgki-ny7xYA9FnVw@mail.gmail.com>
References: <CAK7R4ay5kE-PGkb2qn8xvjsY0nLfMGcGBTztSeAy_9=X_BwmZg@mail.gmail.com> <p2eUiHGGPvgqcEwgk9ISftxabO5Q5sxW6-Eoz-LrbRQBGAPorVnFPKgFaAMeLlfzVQ7Ikwr9vWDa7ctd8t9q_2spBvb2kLW-SyW869R2zQA=@gpb.moe> <CAPyj-LA8eDWBGqYcw7S0DTRZXN1=6HFOncwgki-ny7xYA9FnVw@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Saturday, 17 February 2024 at 22:18, Ilija Tovilo <tovilo.ilija@gmail.co=
m> wrote:

> Right. Consistent code style is nice, but what we have now is really
> not that bad. There are a couple things I'd want if we enforce code
> style:
>=20
> * Fixing the style should be easy, running a single command without
> first pushing to CI.
> * It should be fast too, so that I can easily run it for every commit,
> preferably even on-save in my editor.
> * The new code style should be applied only to newly added sections or
> changed code, not entire files. Otherwise, we'll have many changes in
> large files, with endless merge conflicts when merging up from lower
> branches.

Surely the best way is to apply the formatting tool on all branches that ar=
e supported (even in security support).
Have them be merged upwards, and then add the revisions of the commits to a=
 .git-blame-ignore-revs file so that git blame doesn't care about them.

This should resolve the issue of making future merges difficult.


Best regards,

Gina P. Banyard