Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122424
Date: Sun, 18 Feb 2024 10:27:46 +0000
To: internals@lists.php.net
Subject: Re: [PHP-DEV] Re: [RFC] OOP API for cURL extension
User-Agent: K-9 Mail for Android
In-Reply-To: <9bc2d842-5f56-4062-8b21-3b41310f2c86@app.fastmail.com>
References: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com> <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com> <9bc2d842-5f56-4062-8b21-3b41310f2c86@app.fastmail.com>
Message-ID: <FBA604F7-E7C5-443F-BD3C-CD9F2CE2A597@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: rowan.collins@gmail.com (Rowan Tommins)

On 17 February 2024 15:57:20 GMT, Larry Garfield <larry@garfieldtech=2Ecom>=
 wrote:

>The RFC would also benefit greatly from some practical examples of using =
the new API=2E  Right now it's not clear to me (as someone who almost never=
 uses Curl directly) how/why I'd use any of these, since there's still "a w=
hole crapton of int constants I don't understand floating around=2E"  The s=
uggestion to use an Enum (or several) here is a good one and would help a l=
ot with that, so I'm +1 there=2E

To my mind, the *eventual* aim should be that users don't *need* a userlan=
d wrapper just to make a simple request in a readable way, and that setting=
 raw curl options becomes an advanced feature that most users never need=2E

I know a lot of people's minds will immediately go to request and response=
 objects, but I think we can go a long way by just making well-named method=
s wrapping one or two curl options each, so that you could write this:

$ch =3D new CurlHandle('https://example=2Ecom');
$ch->setMethod('POST');
$ch->setRequestBody('{"stuff":"here"}');
$ch->setBasicAuth('admin', 'correct-horse-battery-staple');
$result =3D $ch->executeAndReturn();

Note that I am not saying every one of those methods needs to be added rig=
ht now; adding a few at a time may be sensible to have time to discuss good=
 names and signatures=2E But to me, renaming CURLOPT_POSTFIELDS to Curl\Str=
ingOptionsEnum::POSTFIELDS doesn't get us very far - users shouldn't need a=
 raw curl setting for such a basic feature in the first place=2E

Regards,

--=20
Rowan Tommins
[IMSoP]