Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:122409 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 6F8E71ADA70 for ; Sat, 17 Feb 2024 13:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1708175743; bh=2p5SeCxlbKPnG3Xj8i2Wsdf/IipqF+kBSepUntGDkoo=; h=Date:To:From:Cc:Subject:In-Reply-To:References:From; b=lZu9dMnrKt6pFe6ADEuGgfagNp9T2Hgvh+3HnFwH8T1hzGHEO+qRSLbdxkD6pjPhF Gijk8f7eKjqGWTZgcXNT/N9TJmENdJTAn8Pr7f9fYmwYyCGNzLEoZ+r964DzEZgGBT 110+v7dhiXUjSeu84zAOEPRVfrE7kWLbdVSpzCAGXXubzXcxw5GmSblgl90+qGdrVu j3H4cYMQarXVau7PLWEvKNNJI9kI8HJX3zV8jLnhmy91j6dyxN4VBdQ+H9/w+UToOW Mhv2ZMUCuFwztw8eqsyiTY1HZVUu94s9H1i+6ur7jROuOWocbz5iXYMhY3OoL5/vXl vFonlhOpmH8tA== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id D37841805BE for ; Sat, 17 Feb 2024 05:15:40 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-40136.proton.ch (mail-40136.proton.ch [185.70.40.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 17 Feb 2024 05:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gpb.moe; s=protonmail; t=1708175733; x=1708434933; bh=2p5SeCxlbKPnG3Xj8i2Wsdf/IipqF+kBSepUntGDkoo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=SFjTZrjlAkudYsE9jnxmNuK9TvgB/HR84JCbWWGSTuKwYVkMPD+/onyVMhEyMKZJV clqtdVYat0HPAIrdsF3YMOkiHBspuJJda6Y5DLNfC6YSras2+8HUjirmmUw+x0+IeO hs5AKSebTfR0CCt3heIb+YBtWKK3X1OxeYmomhltJA4PNVJf8FRjbx41eqRb/VgpZI 6Aft3TBW7MgOGWz/8YsMFrqzSGlR3szrOi3MJMCtPQffb0vhc5KKSPevciI3u69Npz FUrKXSXXwgVs37bRk/FGDgwmpnoRdZxe0zq/F28lrEDTutA5TOUuFR5vRYneUVo578 NTvEtoVNs2K4g== Date: Sat, 17 Feb 2024 13:15:21 +0000 To: Hans Henrik Bergan Cc: PHP Internals List Subject: Re: [PHP-DEV] automatic formatting checks for pull requests? Message-ID: In-Reply-To: References: Feedback-ID: 96993444:user:proton Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: internals@gpb.moe ("Gina P. Banyard") On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan wrote: > Can we add automatic formatting checks for pull requests? > Made a PR: https://github.com/php/php-src/pull/13417 >=20 > php-src use "tabs" instead of "spaces", that is... quite unusual, > and I'm probably not the first person to accidentally use spaces > instead of tabs, ref > https://github.com/php/php-src/pull/13401/files/d64a8ccdc1d21576827059ee8= 6c0fa073c95ffcc#r1492699756 That's quite standard in the C world AFAIK, yes it's not what is standard f= or PHP written code but that's kinda irrelevant. It would be nice to have some formatting rules to harmonize the codebase as= it is somewhat the wild west, but as far as my understanding goes is that Clang format struggles to under= stand our codebase (namely macros) and is difficult to set-up for php-src. Best regards, Gina P. Banyard