Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122408
Precedence: bulk
MIME-Version: 1.0
References: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com>
 <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com>
In-Reply-To: <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com>
Date: Sat, 17 Feb 2024 09:41:40 +0200
Message-ID: <CAJW__o3QKk+ERx0ydtGHdGTA9zBwabEY7vZgDwNwDHoPwEMvWQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] OOP API for cURL extension
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Sara

Den tors. 15. feb. 2024 kl. 21.08 skrev Sara Golemon <pollita@php.net>:
> * Better typing for setOpt() methods.
>   Comment: Yep, this is a good and fair point.  It's going to take a litt=
le more dicing up of the current implementation, but hopefully not too roug=
h.
>   Proposal: Keep untyped setOption() method (1/ Easier migration of exist=
ing code, 2/ Some options may prove difficult to type), but add:
>   * CurlHandle::setOptionBool(int $option, bool $value): CurlHandle
>   * CurlHandle::setOptionInt(int $option, int $value): CurlHandle
>   * CurlHandle::setOptionString(int $option, string $value): CurlHandle
>   * etc... as needed, will this get weird when we get to Array since ther=
e IS a setOptArray?  Maybe we just don't mirror that one, or we call it set=
OptionMany(). Yeah, I like Many for the multiple option set, and Array for =
the single option of array type.
>   Internally, the setopt handler will be split by type so that each typed=
 setting can call explicitly, and the untyped one can call all.

What about making the CURL options an enumeration? It would allow us
to typehint the setOptions() method and we can also make it backwards
compatible with the existing global constants:
```php
public function setOption(CurlOption|int $option, mixed $value): static
{
    if (is_int($option)) {
        $option =3D CurlOption::createFromConstant($option);
    }

    // ...
}
```

The enumeration would then have a static method to transform the
global constant into a native type (which we can do internally).
Naming is obvious just TBD. The biggest potential issue I can see with
this approach is the many conditionally defined constants from older
CURL versions/feature flags from compile time.

From the many type variants of setOptions(), I am uncertain about
that, because with an enumeration, we would still need to have some
sort of whitelisting of what options can be passed into the method.

--=20
regards,

Kalle Sommer Nielsen
kalle@php.net