Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122406
Date: Sat, 17 Feb 2024 11:39:34 +0000
To: PHP internals <internals@lists.php.net>
Subject: [PHP-DEV] Re: [RFC] OOP API for cURL extension
User-Agent: K-9 Mail for Android
In-Reply-To: <EF1C056C-0DE8-425E-80B8-BDC80F22B336@gmail.com>
References: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com> <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com> <EF1C056C-0DE8-425E-80B8-BDC80F22B336@gmail.com>
Message-ID: <50553291-EF85-47CB-99DC-1C4407DE5BA7@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: rowan.collins@gmail.com (Rowan Tommins)

On 16 February 2024 16:09:32 GMT, Rowan Tommins <rowan=2Ecollins@gmail=2Eco=
m> wrote:

>public function executeAndReturn(): string
>public function executeAndOutput(): void

I guess I missed:

public function executeToFile(Stream $fileHandle): void
public function executeWithCallback(callable $wrIteFunction): void

which would imply CURLOPT_FILE and CURLOPT_WRITEFUNCTION, respectively=2E

From=20what I can see, these four modes are actually mutually exclusive (pop=
ulating ch->handlers=2Ewrite->method) with whichever option is touched last=
 governing the actual behaviour of curl_exec()=2E For instance, setting CUR=
LOPT_FILE to null or CURLOPT_RETURNTRANSFER to false always selects stdout =
mode, effectively clearing any value set with CURLOPT_WRITEFUNCTION=2E Havi=
ng separate execute methods would make that much more obvious=2E

Incidentally, I notice there is currently some code in _php_curl_verify_ha=
ndlers where a bad stream in CURLOPT_FILE will fall back to writing the res=
ult to stdout=2E Is it me, or is that a really terrible idea, potentially e=
xposing private data to the user? Should that scenario be promoted to an im=
mediate false return in curl_exec, and Error in the new OO wrapper?

Regards,

--=20
Rowan Tommins
[IMSoP]