Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122397
Date: Fri, 16 Feb 2024 16:09:32 +0000
To: PHP internals <internals@lists.php.net>
Subject: [PHP-DEV] Re: [RFC] OOP API for cURL extension
User-Agent: K-9 Mail for Android
In-Reply-To: <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com>
References: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com> <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com>
Message-ID: <EF1C056C-0DE8-425E-80B8-BDC80F22B336@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: rowan.collins@gmail.com (Rowan Tommins)

On 15 February 2024 15:44:13 GMT, Sara Golemon <pollita@php=2Enet> wrote:
>* CurlHandle::exec() mixed typing of return values=2E
>  Comment: Agreed=2E  The `true` return value becomes meaningless in the
>RETURNTRANSFER=3D=3Dfalse case=2E
>  Proposal: Update the RFC for CurlHandle::execute() to return ?string=2E

Should we take this a step further, and remove CURLOPT_RETURNTRANSFER as a=
 valid option on the object completely? Instead of an overloaded exec() met=
hod, provide:

public function executeAndReturn(): string
public function executeAndOutput(): void

Perhaps the option could be accepted in the relevant setOpt methods, but i=
ssue a warning that it has no effect=2E

Since both the default for the option and the name of the method are chang=
ing anyway, I don't think this significantly affects the migration effort f=
or the tiny minority of cases where you actually want the direct output beh=
aviour=2E

Regards,

--=20
Rowan Tommins
[IMSoP]