Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122393
Message-ID: <ddad1d6c-65a5-470b-9910-668b101f9196@bastelstu.be>
Date: Thu, 15 Feb 2024 21:43:02 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] Re: [RFC] OOP API for cURL extension
Content-Language: en-US
To: internals@lists.php.net
References: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com>
 <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com>
In-Reply-To: <CAESVnVpHRU8-Fc10XEdRkf3tU-5bXxO4tZ-CKwWJeUabB2LM4g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 2/15/24 16:44, Sara Golemon wrote:
> * Define the conditions under which exceptions will be thrown (and which
> exceptions) - I'll add these to the RFC, but in short:
>    * CurlException - Never, it's an interface type to group the other
> exceptions.

Interface or base Exception? I would suggest base exception for 
consistency with \Random\RandomException and \DateException and because 
of the reasoning I gave in this PR:

https://github.com/php/php-src/pull/9220

>    * CurlHandleException - Whenever a CurlHandle::method() fails (in lieu of
> returning false)
>    * CurlMultiException - Same, but for the CurlMultiHandle class.
>    * CurlShareException - Same, but for the CurlShareHandle class.

You already said that you would clarify, but I'm not sure if I find the 
distinction between Handle/Multi/Share useful.

An invalid option being passed to curl_setopt() and curl_multi_setopt() 
is an invalid option in both cases. No need to differentiate the 
exception type, because you know what function you called. In fact it 
should probably be a ValueError and not even something 
ext/curl-specific. Likewise a connection failure would be a connection 
failure, no matter if it is emitted by a handle or a multihandle: This 
could be a CurlConnectException (or possible a namespaced 
Curl\ConnectException).

Best regards
Tim Düsterhus