Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122377
Message-ID: <3b6f13706ccce7b6c52f4477940b950b4ebba600@mail.de>
To: pollita@php.net,
 internals@lists.php.net
Subject: Re: [RFC] OOP API for cURL extension
In-Reply-To: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com>
References: <CAESVnVp11-EVBrhzSj16=Nd3fYE366piq6fG-9wV3+iH8TxchA@mail.gmail.com>
Date: Thu, 15 Feb 2024 08:14:31 +0100
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Mailing-List: contact internals-help@lists.php.net; run by mlmmj
Precedence: bulk
MIME-Version: 1.0
From: christian.stoller@mail.de (Christian Stoller)

Am 15-Feb-2024 03:30:44 +0100 schrieb pollita@php.net:=0A> Good afternoo=
n folks, I'd like to open discussion on adding OOP APIs to the cURL exte=
nsion.=0A> https://wiki.php.net/rfc/curl-oop=0A> =0A> This has been a lo=
ng standing bug-bear of mine, and I think its time has come.=0A> =0A> tr=
y {=0A> =C2=A0 (new \CurlHandle)->setOpt(YOUR_VOTE, true)->exec();=0A> }=
 catch (\CurlHandleException $ex) {=0A> =C2=A0 assert(false); // Why not=
?!=0A> }=0A> =0A> -Sara=0A=0AHi Sara,=0A=0AI like your proposal generall=
y. But I'd suggest to rethink the names of the methods. I understand tha=
t you want to reuse the same names of the procedural version and the und=
erlying lib. But this is the chance to optimize the naming and reduce in=
consistence. In the future this will become harder.=0A=0AFor example the=
re is the getter "getInfo" and some getters without the "get" prefix, li=
ke "errno", "error" and "strerror". I'd suggest to unify them. Either us=
e the "get" prefix for all of those or for none. Personally, I have no p=
articular preference for one of the two options.=0A=0AThe second thing I=
 propose to change is the usage of abbreviations. I'd suggest the follow=
ing mapping for methods of CurlHandle:=0A- errno =3D> errorNumber or get=
ErrorNumber=0A- error =3D> errorMessage or getErrorMessage=0A- strerror=
 =3D> errorMessageByNumber or getErrorMessageByNumber=0A- exec =3D> exec=
ute=0A- setOpt =3D> setOption=0A- setOptArray =3D> setOptionArray=0A=0AT=
here may be better proposals from others.=0A=0AWhat do you think?=0A=0AB=
est regards,=0AChristian