Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122366
MIME-Version: 1.0
References: <CAK7R4azQgqNAbOptoWTZ53Dg61h6h_GBCDZ3sbiPXYBWKHzqJg@mail.gmail.com>
In-Reply-To: <CAK7R4azQgqNAbOptoWTZ53Dg61h6h_GBCDZ3sbiPXYBWKHzqJg@mail.gmail.com>
Date: Wed, 14 Feb 2024 07:48:46 +0700
Message-ID: <CANLbj-o99J10Aad8wfcEuJBaN2QX4RGhFO2u=JX6CxkswbYtDw@mail.gmail.com>
To: Hans Henrik Bergan <hans@loltek.net>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] int|float for DateTime::setTimestamp
From: ayesh@php.watch (Ayesh Karunaratne)

>
> just like the constructor accepts
> new DateTime("@0.123456"); // 1970-01-01 00:00:00.123456
> new DateTime("@".microtime(true));
>
> IMO setTimestamp should accept the same:
> $dt->setTimestamp(0.123456); // 1970-01-01 00:00:00.123456
> $dt->setTimestamp(microtime(true));
>
> Can we change setTimestamp to accept int|float?
> made a PR https://github.com/php/php-src/pull/13383

You are probably already aware, but PHP 8.4 will have a new
`DateTime::get/setMicroseconds` method[^1][^2] that accepts an integer
microsecond value.

That said, I personally think it makes sense to accept float values
for fractions of seconds, but changing the parameter type WILL be be a
BC break because all subclasses extending `setTimestamp` will not be
compatible unless they are changed to `int|float` or wider.


[^1]: https://github.com/php/php-src/commit/0016b3085cf06e8a189ecc53c31697e3a108dbdd
[^2]: https://php.watch/versions/8.4/date-datetime-get-setMicroseconds