Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:122356 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 86377 invoked from network); 10 Feb 2024 19:27:22 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 10 Feb 2024 19:27:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1707593297; bh=bTqMMfH3WbvKljj6iQgSY95kqf3anrzpTYlUlPp047Q=; h=Date:Subject:From:To:References:In-Reply-To:From; b=K+mng7NUvR6Sv98SQzMtPp1FQ6GGLG+QrfO/R/byfdmhswqKm7vJ+IPFq7YF5NyIO LWHdzLnIMvSQOQoa6QuD3Go+o0CeFhIC+ouqCcKHKFNSeLMw3cPsBvERL+nbm8Zx+7 6t4L9gf+AS+xKjOf2OgfL5Iil8XL8GQpGrU0EsGYmz1aDZxmvU1u3mifkn8wylTmW6 0HDt0+s05FnTqVqDbcgbCtBsFR0etX7MCoiaLe5SpRg/3ldEU3ngR3Pt2qJKdCdKWh n3pvE4cbjjvalcLRNE2FPpP2obl5OGMnoVy7GUOyMTwAhzQFIc9tp/tOlPCvUm4Mdv RU9qGjGYXgHbA== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id F40B9180039 for ; Sat, 10 Feb 2024 11:28:14 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 10 Feb 2024 11:28:14 -0800 (PST) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40efcb37373so16314905e9.2 for ; Sat, 10 Feb 2024 11:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707593238; x=1708198038; darn=lists.php.net; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zjFhk4Adrs8HUmwNYqzzcZS++x+vP6/R1yQ8eFkmJ/k=; b=lA6+pNuZCqrZWQeeZpDzf8OeCOJ8zJIkJenJo5hr+sBXVuekfVJdBcvTIdLUi5da0b /CVt2sDmirKHPq7rw80ZFJTcinUbmEY5h1yxWfkejeCJ9FpSKA2r+EmXx/jQ/km+i+/r h73lWzlzKVE2kcYBXtPkqMq92DkvgtLe4IWIpGxdZLPagpaPixjAbliF4HjutmLXXfZK 2ZtxhCA4oG+JafPRJXS+GHTFPgi7TWeoxvBDNrmiamsNMM6GFyf9lboWkQ9bsHGPZFL6 2/pWIrv8W7+jzXuutuxNy9LIiYhrfBznB/GLXyLvbV8N4YTZlOUoLW1QEpibX1yAun2B l2IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707593238; x=1708198038; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zjFhk4Adrs8HUmwNYqzzcZS++x+vP6/R1yQ8eFkmJ/k=; b=arcZctkW/q7PSYx7/9FTqMQ7y1s9Xru20IZGwzKozk2r9Lrl9qbBYObvzYj1lDNQVV S0ynYujLQkbiZ5GsWPLaGAUY5oHAXkc/AgfozA5fLkdSUwt5TUSMw/PUArJaxv/c8yI0 N0w6joP7ZsIYRVQ3gJ7fIp4eLIZGIVrRELZ+/adXIiceU2kH57lGv3ZojXTWSAEFdyF4 bsjI8oFoGIshwQCEt28ox03bhLG/o8ndunLATePKLP3M3FRUCBdDGLxs70EemjpB+Ksg 0jocSkHlodrkq05Z9iJjOyBTc7YAnMbgFutHuD2Q86cvSp4ZsG/TTANxMGgKCu/qBcP6 6HkQ== X-Gm-Message-State: AOJu0YxDcvmiZHk9BarXOYSajJ1imUYhrn03yTsNVmwRGWn78lGeTccz 5uxxw6qXi6di6bAbMD2Mi+au5auzHSrcEH4cnvffjwZu8Ei5jy1zN96lhBJw X-Google-Smtp-Source: AGHT+IFyLOCohOruNc+qzmuG/mUu1AmkmjVvcKroN5f9DZCaOonNr33cdX39+rY/oDxb67xQS8/lBg== X-Received: by 2002:a05:600c:1d03:b0:40f:f891:d282 with SMTP id l3-20020a05600c1d0300b0040ff891d282mr2444841wms.18.1707593238391; Sat, 10 Feb 2024 11:27:18 -0800 (PST) Received: from [192.168.0.59] (178-117-137-225.access.telenet.be. [178.117.137.225]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c225400b004104ecb39d1sm4017885wmm.32.2024.02.10.11.27.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Feb 2024 11:27:18 -0800 (PST) Message-ID: <4b981204-855f-443b-be26-49aba7ca9824@gmail.com> Date: Sat, 10 Feb 2024 20:27:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: PHP internals References: <2006cef3-0e8c-49cc-9703-0fa70690a4ae@gmail.com> In-Reply-To: <2006cef3-0e8c-49cc-9703-0fa70690a4ae@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [RFC] [Discussion] Opt-in DOM spec-compliance From: dossche.niels@gmail.com (Niels Dossche) Hi internals On 1/17/24 21:22, Niels Dossche wrote: > Hi internals > > I'm starting discussion of my RFC "Opt-in DOM spec-compliance". > > RFC link: https://wiki.php.net/rfc/opt_in_dom_spec_compliance > Pre-RFC pitch: https://externals.io/message/122048 > > Kind regards > Niels I basically finished the implementation of the proposal. The only thing remaining is adding more tests, and fixing bugs if any come up. All WPT tests that I ported over (in a separate repo) pass as well. I dropped the importModernNode method from the proposal. Upon trying to implement this, I found that it was too difficult to make it work correctly due to limitations in the import code implementation. In particular, in old DOM, namespaces must always be attached to an element. But when importing a node with namespaced attributes, this could sometimes lose the namespace of those attributes because at that point the cloned subtree is not attached to the document yet. While it's probably possible to fix this for most cases, there will always be cases where this causes issues. As such, I rather not provide this functionality than provide it in a half-working/half-broken state. The reverse direction, importLegacyNode, does not suffer from this problem because we have our own namespace handling code for new DOM. TL;DR: importModernNode is gone, importLegacyNode remains. There has also been no discussion for quite some time now. So if nothing changes, I'd like to put it to vote on Tuesday 13-02. Kind regards Niels