Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122352
MIME-Version: 1.0
References: <CAK=iT=UrMCPw5ydCnxa_87ws6xKRO5Y3qJnmchczgDds8u660A@mail.gmail.com>
 <CAK=iT=UDUjCZ-25k_MkHFO7uKdWAqoJxdWLVBGM2_SYDk-JyAg@mail.gmail.com>
 <742f202d-7990-4f51-b903-7a15e3fd33c2@app.fastmail.com> <CABigaAW2KeGxf7HnzpcOeS=CL31=UNGZnqpZvoJsJg4miBTBGw@mail.gmail.com>
 <1cd8fa7b-ab62-4563-bf13-bb7801f1ce8d@app.fastmail.com> <CAK=iT=X5XKdSZ1D=+SEU4=12hJK+oPn+XBWxA54yyQsxAixx8A@mail.gmail.com>
 <CAOyH9yT5NQQYgq=5O5q==BaTpm-JJRDUcAsX2Tc36hbXLdH5vw@mail.gmail.com>
 <CAK=iT=W7xzS_9FZj-Cd1uUBaLtX=157t81_KOkr999bRyTcDjw@mail.gmail.com>
 <CAOyH9yQKA+RnhXFHvH=dVHT8UWfyF_A89p_c9wES1k4kKstBtA@mail.gmail.com>
 <CAK=iT=VtOx=dZYNMNnn0iVPm4KUy1BoCr07=WYJFR9HJOOKLPg@mail.gmail.com>
 <CAOyH9yTJNq9Y+OcOGw7bkfU7efxoz+0bUt9iyy949_Zj=1_M1g@mail.gmail.com>
 <CAK=iT=VzVOTbqh_v4zcu3MjPq+QzWcstMJnz0z1LPZEbJVVAcQ@mail.gmail.com>
 <90cc47f7-ba80-4798-8447-2f3bb5734eab@app.fastmail.com> <CAK=iT=XNuJMaUD5bNZKODp+3NfbnvJVWdL24BHc71AWAUkDqKw@mail.gmail.com>
 <eaa32340-af2f-496d-a55c-e84aa222dfc4@varteg.nz> <CAK=iT=U4pw8q=Pvgrf_L16S9y0Q4fvAzBKeBDK+Buw1Y+kOt+A@mail.gmail.com>
In-Reply-To: <CAK=iT=U4pw8q=Pvgrf_L16S9y0Q4fvAzBKeBDK+Buw1Y+kOt+A@mail.gmail.com>
Date: Fri, 9 Feb 2024 12:51:57 +0100
Message-ID: <CAPzBOBMMB9==c4WdSUo2HZCRuvHXb+JXMgcKaOxdEMeMNMOoeA@mail.gmail.com>
To: =?UTF-8?B?0JPRgNC40LPQvtGA0LjQuSBTZW5pb3IgUEhQIC8g0KDQsNC30YDQsNCx0L7RgtGH0LjQuiBXZWI=?= <6562680@gmail.com>
Cc: Weedpacket <weedpacket@varteg.nz>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Feature request: https://github.com/php/php-src/issues/13301
From: landers.robert@gmail.com (Robert Landers)

On Thu, Feb 8, 2024 at 8:57=E2=80=AFPM =D0=93=D1=80=D0=B8=D0=B3=D0=BE=D1=80=
=D0=B8=D0=B9 Senior PHP / =D0=A0=D0=B0=D0=B7=D1=80=D0=B0=D0=B1=D0=BE=D1=82=
=D1=87=D0=B8=D0=BA Web
<6562680@gmail.com> wrote:
>
> 1. Do some benchmark with
>
> ```
> <?php
>
> function a($a, $b)
> {
>      return $a + $b;
> }
>
> function aa($a, $b)
> {
>      throw new \Exception();
>
>      return $a + $b;
> }
>
> $bag =3D [];
>
> $mt =3D microtime(true);
>
> for ($i =3D 0; $i < 100000; $i++) {
>    try {
>       a(1,2); // float(0.0023398399353027)
>       // aa(1, 2); // float(0.053406953811646), what 25 times slower?
>    } catch (\Throwable $e) {
>      $bag[] =3D $e;
>    }
> }
>
> var_dump(microtime(true) - $mt);
> ```
>
> 2. Your function is a closed case then. Any error inside that case disabl=
es
> the whole function.
> So the function should be as small as possible, also possible
> repair/fallback/saga functions should be written.
>
> The OOP idea is "the object prepares himself (from inside), or with
> services (from outside)".
> Getters/Setters is bad because only the object should know what's happeni=
ng
> inside.
> Using exceptions you have to write super-micro functions and split your
> logic to hundreds of methods, because any of them could fall with
> exceptions.
> And if you write a Facade that calls one function, each from that calls
> 10-15 internal functions - exactly that facade should decide what to do
> with any occurred exception.
> There are cases you CANNOT decide without third-party libraries. So you
> can't write facades and you should break the encapsulation by doing small
> methods instead of useful ones.
> That's why exceptions are not a solution. Exceptions are a validation cas=
e
> and a safe-shield (reporting to email) for cases you didn't cover because
> of a lot of work.

It's not actually 25x slower, it's only 15x slower to create an
exception. The rest of your overhead is in appending to the array
(~1ms aggregate), throwing (~10ms aggregate).

This isn't even something to worry about though, in most applications.

> Using exceptions you have to write super-micro functions and split your
> logic to hundreds of methods, because any of them could fall with
> exceptions.

I've worked on PHP (and non-PHP) applications with (tens of) millions
of lines of code, and I've never run into this problem. You write
small functions so they can be reusable, not to handle exceptions.
Generally, you don't need to do anything if you rely on types:

function add(int|float $left, int|float $right): int|float { return
$left + $right; }

will throw a TypeError if you call it with strings (at least in strict
mode, in non-strict mode, it will be coerced to a number if a numeric
string), as it should. You shouldn't even have to catch this because
it should be caught in development, and in production, it very much
should crash.

For larger functions/methods, error conditions should be guarded
against through interfaces and types, which will be caught long before
production, either in a code review or in a developer environment.

Robert Landers
Software Engineer
Utrecht NL