Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122343
MIME-Version: 1.0
References: <CAK=iT=UrMCPw5ydCnxa_87ws6xKRO5Y3qJnmchczgDds8u660A@mail.gmail.com>
 <CABigaAUjSx3-vEaQhPk-toJTSg+J3CLrO3otpm1g6hqbYyQKvw@mail.gmail.com>
 <CAK=iT=WgsEZjyu3Y2wTWvycqCsYH7MrLsZgERZK3u75U08ePpA@mail.gmail.com>
 <CAL0xaBHfEMs1BVAMZOuFCUpb9orNSRD0YDhu=3wJAGK7K0_=dg@mail.gmail.com>
 <CAK=iT=XDVcs+y4XDmGu2re137i2yD9LiEj1-HLvyxxxrb8jFUw@mail.gmail.com>
 <CAK=iT=UDUjCZ-25k_MkHFO7uKdWAqoJxdWLVBGM2_SYDk-JyAg@mail.gmail.com>
 <742f202d-7990-4f51-b903-7a15e3fd33c2@app.fastmail.com> <CABigaAW2KeGxf7HnzpcOeS=CL31=UNGZnqpZvoJsJg4miBTBGw@mail.gmail.com>
 <1cd8fa7b-ab62-4563-bf13-bb7801f1ce8d@app.fastmail.com> <CAK=iT=X5XKdSZ1D=+SEU4=12hJK+oPn+XBWxA54yyQsxAixx8A@mail.gmail.com>
 <CAOyH9yT5NQQYgq=5O5q==BaTpm-JJRDUcAsX2Tc36hbXLdH5vw@mail.gmail.com>
 <CAK=iT=W7xzS_9FZj-Cd1uUBaLtX=157t81_KOkr999bRyTcDjw@mail.gmail.com>
 <CAOyH9yQKA+RnhXFHvH=dVHT8UWfyF_A89p_c9wES1k4kKstBtA@mail.gmail.com> <CAK=iT=VtOx=dZYNMNnn0iVPm4KUy1BoCr07=WYJFR9HJOOKLPg@mail.gmail.com>
In-Reply-To: <CAK=iT=VtOx=dZYNMNnn0iVPm4KUy1BoCr07=WYJFR9HJOOKLPg@mail.gmail.com>
Date: Thu, 8 Feb 2024 19:12:18 +0900
Message-ID: <CAOyH9yTJNq9Y+OcOGw7bkfU7efxoz+0bUt9iyy949_Zj=1_M1g@mail.gmail.com>
To: =?UTF-8?B?0JPRgNC40LPQvtGA0LjQuSBTZW5pb3IgUEhQIC8g0KDQsNC30YDQsNCx0L7RgtGH0LjQuiBXZWI=?= <6562680@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Feature request: https://github.com/php/php-src/issues/13301
From: alex.pravdin@interi.co (Alexander Pravdin)

On Thu, Feb 8, 2024 at 6:25=E2=80=AFPM =D0=93=D1=80=D0=B8=D0=B3=D0=BE=D1=80=
=D0=B8=D0=B9 Senior PHP / =D0=A0=D0=B0=D0=B7=D1=80=D0=B0=D0=B1=D0=BE=D1=82=
=D1=87=D0=B8=D0=BA Web
<6562680@gmail.com> wrote:
>
> PHPStan is out the case.
>

May I know why is it out?

I'm actively using it in my projects and it helps me a lot to not
relax and write safe code. It also helps a lot in cleaning up legacy
code. Sometimes I find places in the legacy code where the logic is
too hard to understand in a reasonable amount of time, but they're
rare. These places can be enveloped with additional logging with no
problem.

I'm referring to your initial use case about collecting errors and I'm
suggesting a good tool to solve it. You may start from lower assertion
levels in PHPStan and gradually increase the level to be not ruined by
tons of errors at a time. Of course, I don't know your situation. But
what I do in such cases - is explain to the business the problem and
what steps are required to improve the situation. So the business is
aware of it, the business should not have false impressions about the
code and false expectations from me. Just prefer to be open and tell
the truth. Not prefer to be a yes-man and promise speedy magic
solutions. I'm a professional developer and if I'm asked to do some
crappy coding regularly, I would prefer to leave such a job. My
selling point is to produce high-quality well-architected code.