Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122337
MIME-Version: 1.0
References: <CAK=iT=UrMCPw5ydCnxa_87ws6xKRO5Y3qJnmchczgDds8u660A@mail.gmail.com>
 <CABigaAUjSx3-vEaQhPk-toJTSg+J3CLrO3otpm1g6hqbYyQKvw@mail.gmail.com>
 <CAK=iT=WgsEZjyu3Y2wTWvycqCsYH7MrLsZgERZK3u75U08ePpA@mail.gmail.com>
 <CAL0xaBHfEMs1BVAMZOuFCUpb9orNSRD0YDhu=3wJAGK7K0_=dg@mail.gmail.com>
 <CAK=iT=XDVcs+y4XDmGu2re137i2yD9LiEj1-HLvyxxxrb8jFUw@mail.gmail.com>
 <CAK=iT=UDUjCZ-25k_MkHFO7uKdWAqoJxdWLVBGM2_SYDk-JyAg@mail.gmail.com>
 <742f202d-7990-4f51-b903-7a15e3fd33c2@app.fastmail.com> <CABigaAW2KeGxf7HnzpcOeS=CL31=UNGZnqpZvoJsJg4miBTBGw@mail.gmail.com>
 <1cd8fa7b-ab62-4563-bf13-bb7801f1ce8d@app.fastmail.com> <CAK=iT=X5XKdSZ1D=+SEU4=12hJK+oPn+XBWxA54yyQsxAixx8A@mail.gmail.com>
In-Reply-To: <CAK=iT=X5XKdSZ1D=+SEU4=12hJK+oPn+XBWxA54yyQsxAixx8A@mail.gmail.com>
Date: Thu, 8 Feb 2024 13:27:39 +0900
Message-ID: <CAOyH9yT5NQQYgq=5O5q==BaTpm-JJRDUcAsX2Tc36hbXLdH5vw@mail.gmail.com>
To: =?UTF-8?B?0JPRgNC40LPQvtGA0LjQuSBTZW5pb3IgUEhQIC8g0KDQsNC30YDQsNCx0L7RgtGH0LjQuiBXZWI=?= <6562680@gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Feature request: https://github.com/php/php-src/issues/13301
From: alex.pravdin@interi.co (Alexander Pravdin)

On Thu, Feb 8, 2024 at 2:29=E2=80=AFAM =D0=93=D1=80=D0=B8=D0=B3=D0=BE=D1=80=
=D0=B8=D0=B9 Senior PHP / =D0=A0=D0=B0=D0=B7=D1=80=D0=B0=D0=B1=D0=BE=D1=82=
=D1=87=D0=B8=D0=BA Web
<6562680@gmail.com> wrote:

> I still don't understand why the problem is signature and moving a simple
> throw statement to return type, and then rewriting the catch statement to
> oneline-r.

Sorry for answering not directly to the citation. But from my personal
opinion, a static analyzer like PHPStan with the highest level of
assertion will show you the vast majority of issues in the code,
potential errors, warnings, etc. Just feed your code to it and fix it.
Why do you need to collect errors and warnings on every API call? Edge
cases are called edge because happen rarely and you can react to them
successfully with proper error monitoring. This looks like a bad
design of the app and of the monitoring tools that you propose to
"fix" with bandaids in the language.

>  This is where the so-called SOLID came from, which forces
> everything to be broken down into molecules instead of first closing the
> problem and then deciding whether to break it into parts or leave it that
> way.

This is called not SOLID, this is called a good application
architecture. When an application is designed properly, the delivery
speed is always slow in the beginning. But later it allows much speedy
deliveries because developers don't need to refactor large parts of it
on every new feature. And don't need to rely on bandaids in the
language to save their butt from burning because of working with
shitty architecture.

It is always easy to write down some piece of shit just to close
tickets and fulfill initial requirements and don't care. But I still
don't understand why you keep asking the PHP language community to do
your job and fix your application instead of you?


--
Best, Alexander.