Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122319
Message-ID: <4f175865-1b04-4e1e-a833-e4f463daafbf@varteg.nz>
Date: Wed, 7 Feb 2024 09:39:09 +1300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: internals@lists.php.net
References: <CAK=iT=UrMCPw5ydCnxa_87ws6xKRO5Y3qJnmchczgDds8u660A@mail.gmail.com>
 <CABigaAUjSx3-vEaQhPk-toJTSg+J3CLrO3otpm1g6hqbYyQKvw@mail.gmail.com>
 <CAK=iT=WgsEZjyu3Y2wTWvycqCsYH7MrLsZgERZK3u75U08ePpA@mail.gmail.com>
 <CAL0xaBHfEMs1BVAMZOuFCUpb9orNSRD0YDhu=3wJAGK7K0_=dg@mail.gmail.com>
 <CAK=iT=XDVcs+y4XDmGu2re137i2yD9LiEj1-HLvyxxxrb8jFUw@mail.gmail.com>
 <CAK=iT=UDUjCZ-25k_MkHFO7uKdWAqoJxdWLVBGM2_SYDk-JyAg@mail.gmail.com>
 <742f202d-7990-4f51-b903-7a15e3fd33c2@app.fastmail.com>
 <CAL0xaBFybT7F1J5fMZyz9JkeP79iVveCeFTRUFKzQgdgAPDYPQ@mail.gmail.com>
 <fd672e0b-36d9-41da-abd5-623e4018fb0c@app.fastmail.com>
In-Reply-To: <fd672e0b-36d9-41da-abd5-623e4018fb0c@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Feature request:
 https://github.com/php/php-src/issues/13301
From: weedpacket@varteg.nz (Weedpacket)

On 2024-02-07 09:08, Larry Garfield wrote:
> 
> "The right tool for the job" is indeed the strongest argument for lightweight exceptions.  It's a tool we lack right now.
> 
> I'm thinking not of "DB went away" type issues (Exceptions are already fine there), but "requested product not found."  Right now, the options we have are:
> 
> ...
> 
> The first is probably most common, but null (as I go into in the article) doesn't tell you anything and leads to mismatch errors.
> 
> Exceptions, I'd argue, are just plain wrong in this situation.  (Which means, yes, all the frameworks that throw exceptions on route-not-found are doing it wrong.)
> 
> And the union-enum approach is a bit clunky as it has no native language support, and no solid conventions behind it.  This is my preferred approach personally today, but I think we can do better.  Even just having this available at all means that "well everyone just uses unchecked exceptions" isn't entirely true.  (All three of the above can be found in the wild.)
> 

I can add a fourth option for the "get record by ID" that may not be 
found, that I've seen in the wild:

public function find($id): ProductSet {}

Where the ProductSet is a collection of (in this case) no more than one 
Product. It's up to the caller to verify there actually is a Product 
inside and extract it, and it's also the caller's decision whether not 
finding one is a problem or not.

Of course, in this domain it folded in with using ProductSets to 
represent more general collections of Products and the resulting set 
algebra.

Weedpacket