Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122306
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
MIME-Version: 1.0
Message-ID: <33dda53d-e4f8-42f0-a4ca-08271aba045c@app.fastmail.com>
In-Reply-To: <BF0589E0-D555-4CCD-B68B-253C73325933@sakiot.com>
References: <1d6e1a6a-7508-40d1-a146-a7b9f67327b4@app.fastmail.com>
 <BF0589E0-D555-4CCD-B68B-253C73325933@sakiot.com>
Date: Tue, 06 Feb 2024 17:15:57 +0000
To: "Saki Takamachi" <saki@sakiot.com>
Cc: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [Proposal] Add `savepoint()` method to PDO
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Feb 6, 2024, at 2:28 PM, Saki Takamachi wrote:
> Hi Larry,
>
>> I like this proposal.  It's a good incremental improvement to PDO.  I also agree with rollbackTo(), to avoid confusion.
>
> Thank you, I'm glad to receive your positive feedback.
>
> It is very difficult to implement these in pdo_odbc because the odbc 
> API does not support savepoint.
>
> However, since odbc itself is quite old, it may be a good idea to make 
> only pdo_odbc incompatible with the savepoint method.

There's been discussion recently about how to deal with incompatibilities between different PDO drivers, especially now that we can have subclasses per driver.  That may be the way to deal with it.  I don't have a major opinion on the approach, other than all incompatibilities should be handled in a consistent way.

--Larry Garfield