Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122284
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Mon, 5 Feb 2024 22:54:23 +0900
Message-ID: <26F6121A-293E-45E7-B8A5-DA1D02742D28@sakiot.com>
References: <CAON3zHAyO=Y-k80GTcf_pdKJWQcn=E__Y_466-zXDrU7yq6UrA@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CAON3zHAyO=Y-k80GTcf_pdKJWQcn=E__Y_466-zXDrU7yq6UrA@mail.gmail.com>
To: Kentaro Takeda <takeda@youmind.jp>
Subject: Re: [PHP-DEV] [Proposal] Add `savepoint()` method to PDO
From: saki@sakiot.com (Saki Takamachi)

Hi Kentaro,

Thank you for your important point.

> While most databases use `SAVEPOINT [name]`, but:
>=20
> https://github.com/laravel/framework/blob/v10.43.0/src/Illuminate/Database=
/Query/Grammars/SqlServerGrammar.php#L453-L456
>=20
> ```php
> return 'SAVE TRANSACTION '.$name;
> ```
>=20
> SQL Server uniquely uses `SAVE TRANSACTION [name]`. There might be
> other variations in databases, so full support could be challenging,
> which is something to be mindful of.

I think this feature will be implemented for each driver, so it probably won=
't be a problem for anything other than pdo_odbc. As you say, I think I need=
 to think a little more about pdo_odbc.

(When I looked into odbc3 again, I realized that what I had written was not a=
n API for odbc, sorry. Therefore, it may be difficult to support this featur=
e stably with ODBC.)

I'll see if there's a better way.

>> change the signature of `rollback()` to `rollback(?string $name =3D null)=
`.
>=20
> This might lead to confusion due to `rollback()` having multiple
> functionalities, as `ROLLBACK` and `ROLLBACK TO [name]` target
> different rollback operations.
>=20
> Just as `beginTransaction()` and `savepoint()` are separate, perhaps
> having a separate method for rolling back to a savepoint might
> maintain consistency, for example `rollbackToSavepoint(string $name)`.

Regarding this, mysqli's `rollback()` is such a specification, so I used tha=
t as a reference. However, it may be safer to separate the method itself.

`rollbackTo()` might also be good.

Regards.

Saki=