Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122283
MIME-Version: 1.0
References: <325E790F-5E88-4559-862F-6C4ACBC89779@sakiot.com>
In-Reply-To: <325E790F-5E88-4559-862F-6C4ACBC89779@sakiot.com>
Reply-To: Kentaro Takeda <takeda@youmind.jp>
Date: Mon, 5 Feb 2024 21:35:43 +0900
Message-ID: <CAON3zHAyO=Y-k80GTcf_pdKJWQcn=E__Y_466-zXDrU7yq6UrA@mail.gmail.com>
To: Saki Takamachi <saki@sakiot.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [Proposal] Add `savepoint()` method to PDO
From: internals@lists.php.net ("Kentaro Takeda via internals")

Hi Saki,

Aside from a few concerns, I think your proposal is very sensible.

I have long felt a disconnect that while we have `beginTransaction()`,
`commit()`, and `rollback()` methods, there's no equivalent
functionality for `SAVEPOINT` in PDO. It seems natural to support
these commonly used transactional features as part of PDO's
functionality.

Having consistent support through PDO would be greatly appreciated
from a user perspective, but I do have concerns regarding the
variations in SQL. The following code is quoted from Laravel:

https://github.com/laravel/framework/blob/v10.43.0/src/Illuminate/Database/Query/Grammars/Grammar.php#L1307-L1310

```php
return 'SAVEPOINT '.$name;
```

While most databases use `SAVEPOINT [name]`, but:

https://github.com/laravel/framework/blob/v10.43.0/src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php#L453-L456

```php
return 'SAVE TRANSACTION '.$name;
```

SQL Server uniquely uses `SAVE TRANSACTION [name]`. There might be
other variations in databases, so full support could be challenging,
which is something to be mindful of.

> change the signature of `rollback()` to `rollback(?string $name = null)`.

This might lead to confusion due to `rollback()` having multiple
functionalities, as `ROLLBACK` and `ROLLBACK TO [name]` target
different rollback operations.

Just as `beginTransaction()` and `savepoint()` are separate, perhaps
having a separate method for rolling back to a savepoint might
maintain consistency, for example `rollbackToSavepoint(string $name)`.

Regards.

Kentaro