Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122268
Date: Wed, 31 Jan 2024 00:34:04 +0000
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Message-ID: <uQSkriES76JwWuvLxCDz6A4-TF2u2nU4POCTFhRowgARdtAK4CWB3abcsiKZaRuxXtLWLhSR-DK8avdg5VlFJ7gpNV5Ui1aslF3QTq50-MA=@gpb.moe>
In-Reply-To: <CAOWwgpksvD7mcrxQQ7rc2hu4WpZCDdh+-fTJKsu6ssBx4p9ynw@mail.gmail.com>
References: <JmodrpwuVz43pzkm6Ok1P6SNx-ayT9ZJ1EvPazHh1Jqp7uT-RsqomzHc2-YYC2Qhq6DqJzWcltUMxo0xnAxpEWi8gccFPwJN7t43vkchbl8=@gpb.moe> <CAOWwgpksvD7mcrxQQ7rc2hu4WpZCDdh+-fTJKsu6ssBx4p9ynw@mail.gmail.com>
Feedback-ID: 96993444:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function
From: internals@gpb.moe ("Gina P. Banyard")

On Tuesday, 30 January 2024 at 08:48, Nicolas Grekas <nicolas.grekas+php@gm=
ail.com> wrote:

>=20
> In Symfony's HttpClient, we use stream_get_meta_data($h)['wrapper_data'] =
to
> access headers, so there is already a way to get them using nothing but
> local scope.
>=20
> This makes me wonder why, in "rejected ideas", you wrote this?
>=20
> > One suggested idea was to provide those headers via a by-reference entr=
y
> > to the stream context.
>=20
>=20
>=20
> Maybe we don't need anything but to promote what works already (this
> "wrapper_data" entry)?

The issue is this requires you to have a stream in the first place.
file_get_contents() doesn't return a stream, and if the request fails fopen=
(), by default, returns false.

If you do have a stream, then yes stream_get_meta_data() is better, but the=
 objective of this addition is to replace the $http_request_header variable=
 so that it can be removed.
This is a rather fringe feature, and thus I expect these functions to also =
be a fringe feature.

Best regards,

Gina P. Banyard